xds/client: move unmarshal functions and types to a separate package #4904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
xds_client_ractor
branch
4 times, most recently
from
62c8ed7
to
2daeb74
Compare
|
|
menghanl
force-pushed
the
xds_client_ractor
branch
from
cf2c45e
to
b4b171f
Compare
|
Tests fixed |
menghanl
force-pushed
the
xds_client_ractor
branch
from
b4b171f
to
81773bf
Compare
easwars
reviewed
Oct 29, 2021
|
|
||
| // Package resource contains functions to proto xds updates (unmarshal from | ||
| // proto), and types for the resource updates. | ||
| package resource |
There was a problem hiding this comment.
Should we call this xdsresource instead? I don't feel strongly either way, but wanted to know if you considered that and rejected it, and if so, for what reasons.
menghanl
force-pushed
the
xds_client_ractor
branch
from
fa0ccfb
to
c43610f
Compare
|
Could you please handle the merge conflicts. Thanks. |
menghanl
force-pushed
the
xds_client_ractor
branch
2 times, most recently
from
7f073da
to
dfbd7d6
Compare
|
Done |
easwars
approved these changes
Nov 4, 2021
| _ "google.golang.org/grpc/xds/internal/xdsclient/v2" // V2 client registration. | ||
| "google.golang.org/grpc/xds/internal/xdsclient/xdsresource" |
There was a problem hiding this comment.
Nit: join this import with the other block?
There was a problem hiding this comment.
Did you mean "not join"?
[xds_client_ractor] package comment [xds_client_ractor] add (s) to all tests, try to fix tlogger race
menghanl
force-pushed
the
xds_client_ractor
branch
from
6f58abe
to
d96fdb6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup PR, part of a bigger effort to refactor and cleanup the
xdsclientpackage.This moves unmarshal functions and types to a separete
xdsclient/resourcepackage:Unmarshalfunctions (e.g.UnmarshalListener)ListenerUpdate)FilterChainManageris also movedThose functions don't rely on xdsclient details (ClientConn, stream, or even the watchers/callbacks). And they are a huge part of the xdsclient package, making it hard to maintain.
RELEASE NOTES: N/A