Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/circuit_breaking: counters should be keyed by {cluster, EDS service name} pair #4560

Merged

Conversation

menghanl
Copy link
Contributor

…aking: use cluster name as key, not EDS service name
@menghanl menghanl requested a review from dfawley June 21, 2021 21:52
@menghanl menghanl added this to the 1.40 Release milestone Jun 21, 2021
@@ -606,7 +606,7 @@ func (s) TestCircuitBreaking(t *testing.T) {

// Since the counter's max requests was set to 1, the first request should
// succeed and the second should fail.
counter := xdsclient.GetServiceRequestsCounter(serviceName)
counter := xdsclient.GetClusterRequestsCounter(serviceName, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the parameters here reversed?

Copy link
Contributor Author

@menghanl menghanl Jun 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are just bad testing const names...

@dfawley dfawley assigned menghanl and unassigned dfawley Jun 21, 2021
@menghanl menghanl force-pushed the circuit_breaking_both_cluster_and_service branch from aacb784 to fbfb344 Compare June 21, 2021 23:31
@menghanl menghanl merged commit 14c7ed6 into grpc:master Jun 22, 2021
@menghanl menghanl deleted the circuit_breaking_both_cluster_and_service branch June 22, 2021 18:03
spirt-t pushed a commit to spirt-t/grpc-go that referenced this pull request Oct 13, 2021
commit 2fe71180762478c66b0027f780b95c40fc563a55
Author: Menghan Li <[email protected]>
Date:   Mon Oct 11 15:42:10 2021 -0700

    xds/e2e: move flag check to each test, and call t.Skip() (#4861)

commit ea41fbfa10817592c85b4ada15d3d1ba3d6fdae7
Author: Easwar Swaminathan <[email protected]>
Date:   Mon Oct 11 14:55:45 2021 -0700

    examples: unix abstract socket (#4848)

commit 6c56e211a0691f83bb59c5100e79f25d04cd4bb0
Author: Easwar Swaminathan <[email protected]>
Date:   Mon Oct 11 14:55:12 2021 -0700

    grpclb: add `target_field` to service config (#4847)

commit 49f638878973e2ccc20859209a73e1c3a02de015
Author: Menghan Li <[email protected]>
Date:   Mon Oct 11 11:06:15 2021 -0700

    grpclog: support formatting output as JSON (#4854)

commit b99d1040b71caf9b22be570edb68d85dcb6c515c
Author: Ashitha Santhosh <[email protected]>
Date:   Fri Oct 8 17:09:55 2021 -0700

    authz: create file watcher interceptor for gRPC SDK API (#4760)

    * authz: create file watcher interceptor for gRPC SDK API

commit 03ca7b7d00cada2ff8a3ea7348fe6c3a2b2ee4fb
Author: Zach Reyes <[email protected]>
Date:   Thu Oct 7 22:46:49 2021 -0400

    Added logs to rbac (#4853)

    Added logs to rbac

commit 524d10cbce3e1c597c48589341c01332f71c3d93
Author: Terry Wilson <[email protected]>
Date:   Thu Oct 7 11:58:49 2021 -0700

    kokoro: source test driver install script from core repo (#4825)

commit b9d7c74e01f89a52880332f584776ccfe0c27756
Author: Menghan Li <[email protected]>
Date:   Thu Oct 7 11:47:53 2021 -0700

    xds: local interop tests (#4823)

commit 404d8fd5139bfb7be9b4bf675e76eed53207dd8c
Author: Zach Reyes <[email protected]>
Date:   Wed Oct 6 19:26:43 2021 -0400

    Added imports for HTTP Filters (#4850)

    Added imports for HTTP Filters

commit d16cfedb5f31caad933f6bb4f3aa3a85177fb989
Author: Zach Reyes <[email protected]>
Date:   Wed Oct 6 19:26:22 2021 -0400

    Rename env var (#4849)

    Rename env var

commit 4bd99953513f3d9de6a75075cfb51bc2224429e0
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Oct 5 16:55:25 2021 -0700

    xds: suppress redundant resource updates using proto.Equal (#4831)

commit ee479e630f859849f23d70ebf2fa3021f5ad2658
Author: Menghan Li <[email protected]>
Date:   Tue Oct 5 14:49:15 2021 -0700

    creds/google: replace NewComputeEngineCredsWithOptions with NewDefaultCredentialsWithOptions (#4830)

commit 02da625150e8ee126d4b84dfed27d2453f2617f4
Author: Doug Fawley <[email protected]>
Date:   Mon Oct 4 14:01:09 2021 -0700

    github: increase timeout for codeql and disable for PRs (#4841)

commit f2974e7778b189c094a2d5fe087d680f7a72050e
Author: Menghan Li <[email protected]>
Date:   Mon Oct 4 11:54:27 2021 -0700

    kokoro: remove expired letsencrypt.org cert and update (#4840)

commit f068a13ef05d63510828ed59e7cf3651a02c7118
Author: Doug Fawley <[email protected]>
Date:   Mon Oct 4 11:22:00 2021 -0700

    server: add missing conn.Close if the connection dies before reading the HTTP/2 preface (#4837)

commit 09970207abb5f88aeb1b31fd1190a0934e302e0f
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Oct 1 15:27:28 2021 -0700

    xds: remove race in TestUnmarshalCluster_WithUpdateValidatorFunc (#4836)

commit b9f62538f003011893c70991c36bdb5b680eed8e
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Oct 1 11:09:26 2021 -0700

    rls: pull proto changes made in grpc-proto/pull/98 (#4832)

commit 69e1b54deb77c76b6832f36e4b31d4316a34f17d
Author: Doug Fawley <[email protected]>
Date:   Fri Oct 1 11:09:12 2021 -0700

    test: fix stayConnected to call Connect after state reports IDLE (#4821)

commit 127c052c701b81daa5970c695438f6ef08c76040
Author: Mohan Li <[email protected]>
Date:   Thu Sep 30 13:06:50 2021 -0700

    credentials/google: introduce a new API `NewComputeEngineCredsWithOptions` (#4767)

commit 2ae5ac1637d68d584d20815d965538481a3c11c7
Author: Easwar Swaminathan <[email protected]>
Date:   Thu Sep 30 10:04:19 2021 -0700

    xds: nack if certprovider instance name is missing in bootstrap config (#4799)

commit adb21c46100568b95ab41e97e3b267923a0a92a0
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Sep 29 16:58:46 2021 -0700

    rls: improve config parsing (#4819)

commit e6d0d2818a7380920b806ae629320500e739bd5c
Author: Menghan Li <[email protected]>
Date:   Tue Sep 28 13:55:29 2021 -0700

    internal: log SubConn type if it's not the expected type (#4813)

commit 34df1b42aecf459d913a1b6aaf835e1d4eea22d3
Author: Zach Reyes <[email protected]>
Date:   Tue Sep 28 15:27:00 2021 -0400

    xds: Small RBAC Changes defined in A41 (#4818)

    * xds: Small RBAC Changes defined in A41

commit 75f1d4b986342c24fab707fc6be37c51f9f8ee50
Author: Doug Fawley <[email protected]>
Date:   Tue Sep 28 12:20:57 2021 -0700

    transport: call stats handler for trailers before closeStream (#4816)

commit 08927214a41e3a2d937658689167363942c06426
Author: Menghan Li <[email protected]>
Date:   Tue Sep 28 10:11:52 2021 -0700

    xds/rds: NACK unknown route action cluster specifier (#4788)

commit 710419d32bfd469509bae5b73274f5825ad13554
Author: ZhenLian <[email protected]>
Date:   Mon Sep 27 16:42:32 2021 -0700

    advancedtls: add revocation support to client/server options (#4781)

commit 4555155af248cab3368e5c5e650bd216366c8bb5
Author: Zach Reyes <[email protected]>
Date:   Mon Sep 27 17:36:16 2021 -0400

    xds: Small changes at xDS RBAC Layer (#4815)

    * xds: Small changes at xDS RBAC Layer

commit 689f7b154ee8a3f3ab6a6107ff7ad78189baae06
Author: Zach Reyes <[email protected]>
Date:   Mon Sep 27 16:55:46 2021 -0400

    transport: logic specified in A41 to support RBAC xDS HTTP Filter (#4803)

    * transport: logic specified in A41 to support RBAC xDS HTTP Filter

commit 11437f66f20f3473e09fcf3fb5c23d4388af936f
Author: Doug Fawley <[email protected]>
Date:   Fri Sep 24 15:29:25 2021 -0700

    test: add option to make httpServer wait for END_STREAM; fix RetryStats race (#4811)

commit 6ff68b489ecba2884aff152835d745389598935a
Author: Doug Fawley <[email protected]>
Date:   Thu Sep 23 14:40:18 2021 -0700

    channelz: recommend using admin.Register instead (#4797)

commit 78d3aa8b3ed1b59bf84db4242ac7c316e8943797
Author: Easwar Swaminathan <[email protected]>
Date:   Thu Sep 23 07:43:14 2021 -0700

    grpc: cleanup parse target and authority tests (#4787)

commit 83a3461520f69c1896990dfae724101c1ed6a1d2
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Sep 22 17:43:36 2021 -0700

    xds: have separate tests for RBAC on and off (#4807)

commit d7208f02ca7721bef504d100b61c1ef8cd569390
Author: Doug Fawley <[email protected]>
Date:   Wed Sep 22 16:35:39 2021 -0700

    github: set a shorter timeout on testing jobs (#4806)

commit 32cd3d617642c49c435ab2a435e716efd4a5e949
Author: apolcyn <[email protected]>
Date:   Wed Sep 22 16:08:17 2021 -0700

    interop: don't use WithBlock dial option in the client (#4805)

commit d623accd30f0f13047e6e2b7147aee41691054c3
Author: Menghan Li <[email protected]>
Date:   Wed Sep 22 16:01:18 2021 -0700

    xds: fix parent balancers to handle Idle children (#4801)

commit e6246c22eb0440d525ce1c226b0c9f1ea9ea693a
Author: Evan Jones <[email protected]>
Date:   Wed Sep 22 16:30:27 2021 -0400

    server: optimize chain interceptors (-1 allocation, -10% time/call) (#4746)

commit 458ea7640a92039aad37edc67b63e6d040a93320
Author: Zach Reyes <[email protected]>
Date:   Wed Sep 22 15:08:44 2021 -0400

    xds: Added validations for HCM to support xDS RBAC Filter (#4786)

    * xds: Added validations for HCM to support xDS RBAC Filter

commit 1f12bf44284e6ba4be72cd028a2a1eb01c2d18bb
Author: Yury Frolov <[email protected]>
Date:   Wed Sep 22 23:04:45 2021 +0500

    transport: fix a typo in http2_server.go (#4745)

commit 606403ded29c7b922a66b4c5a449a1643269bc96
Author: Zach Reyes <[email protected]>
Date:   Tue Sep 21 19:33:18 2021 -0400

    transport: fix log spam from Server Authentication Handshake errors (#4798)

    * transport: fix log spam from Server Authentication Handshake errors

commit 616977cc7974d6cbec50399297db7026d791c9dd
Author: Doug Fawley <[email protected]>
Date:   Tue Sep 21 11:32:51 2021 -0700

    Change version to 1.42.0-dev (#4793)

commit 4ddf8ceaa7b5de2170b082bfc7162c4887ddaeb5
Author: Doug Fawley <[email protected]>
Date:   Tue Sep 21 10:55:00 2021 -0700

    Revert "transport/server: add :method POST to incoming metadata (#4770)" (#4790)

    This reverts commit c84a5de06496bf8416cebf9d0058f481e37c165e.

commit d53469981f2356f7c270d4b3beaafc6d1a653817
Author: Doug Fawley <[email protected]>
Date:   Tue Sep 21 10:39:59 2021 -0700

    transport: fix transparent retries when per-RPC credentials are in use (#4785)

commit 5417cf809116a5e3e8ca06b15cb48cbffb946204
Author: Menghan Li <[email protected]>
Date:   Mon Sep 20 13:27:27 2021 -0700

    xds/test: delete use of removed types (#4784)

    They were deprecated, and removed later.

commit 1109452fd118ec20164e859f71c0bb59fd209d21
Author: Lidi Zheng <[email protected]>
Date:   Fri Sep 17 15:19:26 2021 -0700

    [Backport grpc#27373] add testing_version flag (#4783)

commit e469f0d5f5bcc1324dc3940c584e0969e2ea1f90
Author: Zach Reyes <[email protected]>
Date:   Fri Sep 17 01:01:07 2021 -0400

    xds: Add env var protection for RBAC HTTP Filter (#4765)

    * xds: Add env var protection for RBAC HTTP Filter

commit 567da6b86340a83d509467638c91e68168bc1921
Author: Menghan Li <[email protected]>
Date:   Thu Sep 16 13:38:35 2021 -0700

    tlogger: print log type (#4774)

    Error logs cause tests to fail. This makes it easier (possible) to find
    the error log

commit 03b2ebe5080c2b521c742cf6e06bd0824b75fc52
Author: Menghan Li <[email protected]>
Date:   Thu Sep 16 11:07:04 2021 -0700

    xds: enable ringhash and retry by default (#4776)

commit b186ee8975f3c69bc36333a99fc82d1388977012
Author: Ed Warnicke <[email protected]>
Date:   Thu Sep 16 09:59:36 2021 -0500

    test/bufconn: add Listener.DialContext(context.Context) (#4763)

commit 7cf9689be2d2b1e7f00dfc15d2516b7635c65c45
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Sep 15 15:38:01 2021 -0700

    xds: validations for security config, as specified in A29 (#4762)

    * xds: validations for security config, as specified in A29

    * make vet happy

    * fix error log

    * fix error msg in test

commit 4f093b9a5afa5f3c8f29774dbdce8c02ce516d70
Author: Menghan Li <[email protected]>
Date:   Wed Sep 15 14:47:18 2021 -0700

    ringhash: the balancer (#4741)

commit 4c5f7fb0eecd984708e0c1eeea7d426f275b22d3
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Sep 15 14:05:59 2021 -0700

    xds: de-experimentalize xDS apis required for psm security (#4753)

commit c84a5de06496bf8416cebf9d0058f481e37c165e
Author: Zach Reyes <[email protected]>
Date:   Wed Sep 15 17:02:08 2021 -0400

    transport/server: add :method POST to incoming metadata (#4770)

    * transport/server: add :method POST to incoming metadata

commit 98ccf472da9a7e01d53bd27e5ad537d46c1b5ca9
Author: Menghan Li <[email protected]>
Date:   Wed Sep 15 13:35:51 2021 -0700

    priority: handle Idle children the same way as Ready (#4769)

commit 2d4e44a0cd75808908c9fb98aac764af6558ff6e
Author: Menghan Li <[email protected]>
Date:   Tue Sep 14 16:11:03 2021 -0700

    xds/affinity: fix bugs in clusterresolver and xds-resolver (#4744)

commit d41f21ca050b1721093702ede81c21b7e3bdaa63
Author: Doug Fawley <[email protected]>
Date:   Tue Sep 14 15:11:42 2021 -0700

    stats: support stats for all retry attempts; support transparent retry (#4749)

commit 5d8e5aad40bedb696205b96b786f1d0e1326b3f8
Author: Kobi <[email protected]>
Date:   Tue Sep 14 17:15:02 2021 +0300

    Create NOTICE.txt (#4739)

commit 5bfc05fb0cf08fd2a8257d2bca8dba552263ba7e
Author: Easwar Swaminathan <[email protected]>
Date:   Mon Sep 13 11:50:52 2021 -0700

    grpc: clarify the use of transport.ErrConnClosing from createTransport() (#4757)

commit 77ffb2ef318a2b8442b9fb10f80724013b2e65eb
Author: Zach Reyes <[email protected]>
Date:   Mon Sep 13 14:09:57 2021 -0400

    xds: RBAC HTTP Filter (#4748)

    * xds: RBAC HTTP Filter

commit 03268c8ed29e801944a2265a82f240f7c0e1b1c3
Author: Doug Fawley <[email protected]>
Date:   Fri Sep 10 16:25:09 2021 -0700

    balancer: fix aggregated state to not report idle with zero subconns (#4756)

commit d25e31e741ddfb45f4126cd20e357185751e42c2
Author: Doug Fawley <[email protected]>
Date:   Fri Sep 10 14:12:13 2021 -0700

    client: fix case where GOAWAY would leak connections and memory (#4755)

commit 7f560ef4c5224efb8a86f2877315c381c30fa126
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Sep 10 14:08:26 2021 -0700

    grpc: close underlying transport when subConn is closed when in connecting state (#4751)

commit 4e07a14b4e66e90ebf54ccc361012cb2b10724fd
Author: Cesar Ghali <[email protected]>
Date:   Fri Sep 10 13:58:12 2021 -0700

    credentials/ALTS: Ensure ALTS record protocol names are consistent (#4754)

commit 16cf65612e633d1cc0be8c65ee7a49fbe2b27825
Author: Menghan Li <[email protected]>
Date:   Fri Sep 10 11:24:25 2021 -0700

    xds: update xdsclient NACK to keep valid resources (#4743)

commit 43e8fd4f69b65fd51d72578df4afa5c0519ca2b5
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Sep 10 10:59:25 2021 -0700

    xds: don't remove env var protection for security on the client yet (#4752)

    Set the value to true by default, and remove it one release later.

commit 0a99ae2d035feeb87506e767bd88d3b7364d1059
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Sep 10 09:04:59 2021 -0700

    xds: support new fields to fetch security configuration (#4747)

commit 2608e38e6386be7400720fecf2ece176c4cbc1b2
Author: Zach Reyes <[email protected]>
Date:   Thu Sep 9 13:35:41 2021 -0400

    xds: Added server side routing (#4726)

    * Added server side routing

commit 1fe5adbbf82f15781a0ce3f704012dc44e6b8e63
Author: apolcyn <[email protected]>
Date:   Wed Sep 8 17:31:51 2021 -0700

    interop-testing: add soak test cases to interop client (#4677)

commit a6a63177ae6094f9baa83b046bb4f20426ba5b82
Author: Doug Fawley <[email protected]>
Date:   Wed Sep 8 10:00:44 2021 -0700

    xds: add retry support (#4738)

commit 2f3355d2244eb436564a93dfbe2b0ba907adeb98
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Sep 7 11:11:16 2021 -0700

    xds: update go-control-plane to latest (#4737)

commit 973e7cb9a17d398b9ddff102e19701f9e7a7a096
Author: Menghan Li <[email protected]>
Date:   Tue Sep 7 10:41:26 2021 -0700

    ringhash: the picker (#4730)

commit 00a7dc8901e6f74713b131601d76cfc8fb62f8b0
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Sep 7 10:28:56 2021 -0700

    xds: remove env var protection for security on client (#4735)

commit c99a9c19b08500bd4259e95e3529ff483a0ae405
Author: Menghan Li <[email protected]>
Date:   Tue Sep 7 10:10:36 2021 -0700

    priority: forward the first IDLE state and picker (#4731)

commit 0ca7dca97726252050774a4bff20d92ca5772331
Author: yihuaz <[email protected]>
Date:   Tue Sep 7 09:12:01 2021 -0700

    oauth: Allow access to Google API regional endpoints via Google Default Credentials (#4713)

commit b2ba77a36ff809ab344b98368d9ecc3e12f943d6
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Sep 3 10:59:33 2021 -0700

    xds: use separate update channels for listeners in test (#4712)

commit c93e472777b9d2963eff865ff4ee9f0895876b43
Author: Zach Reyes <[email protected]>
Date:   Thu Sep 2 14:43:26 2021 -0400

    Fixed race in Filter Chain (#4728)

commit b189f5e1bc9a495447332355df8a9648e65a2e44
Author: Ashitha Santhosh <[email protected]>
Date:   Thu Sep 2 11:22:07 2021 -0700

    authz: create interceptors for gRPC security policy API (#4664)

    * Static Authorization Interceptor

commit d6a5f5f4f3621542ec98cfed52c0620beab9fbd5
Author: Menghan Li <[email protected]>
Date:   Thu Sep 2 10:49:35 2021 -0700

    ringhash: the ring (#4701)

commit 51003aa81e09b20c1a74ec88c961a68902349143
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Sep 1 13:49:44 2021 -0700

    xds: start a management server per test (#4720)

commit ed501aa1fd1d368d77e17de619046e2e1ebb82a9
Author: Tobias Klauser <[email protected]>
Date:   Wed Sep 1 20:08:00 2021 +0200

    xds/internal/resolver: update github.com/cespare/xxhash to v2 (#4671)

    github.com/cespare/xxhash/v2 supports Go ≥ 1.11 and this package states
    1.11 in its go.mod file. The only symbol used from the xxhash package is the
    Sum64String func which still exists and works the same in v2.

    This gets rid of two indirect dependencies.

commit f7d66b5846f00b6ab0b41a675aef9764176830fa
Author: Lidi Zheng <[email protected]>
Date:   Tue Aug 31 13:42:43 2021 -0700

    Change to a non-workload-identity GKE cluster (#4723)

commit 198d951db5082bddddd36e53efa8e9cbc924a228
Author: Zach Reyes <[email protected]>
Date:   Tue Aug 31 09:27:06 2021 -0400

    xds: Instantiated HTTP Filters on Server Side (#4669)

    * Instantiated HTTP Filters on Server Side

commit ef66d13abb84ad6c6d99c8cbf3697607b7891f32
Author: Zach Reyes <[email protected]>
Date:   Mon Aug 30 16:49:46 2021 -0400

    xds: Required Router Filter for both Client and Server side (#4676)

    * Added isTerminal() to FilterAPI and required router filter on Client and Server side

commit 85b9a1a0fa3fc7ce6677ac19267b380ef0cf59a7
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Aug 27 08:18:29 2021 -0700

    xds: pass empty balancer.BuildOptions in clusterresolver_test (#4711)

commit 43b19ef0e473c675b0ec7666a9856bf5edd7439e
Author: Doug Fawley <[email protected]>
Date:   Thu Aug 26 13:29:59 2021 -0700

    grpctest: extend use of mutex to guard more things (#4710)

commit d074cae66bc68d4ec5ccf427de2fce700223f4c7
Author: Doug Fawley <[email protected]>
Date:   Thu Aug 26 11:21:36 2021 -0700

    github: fold security tests into 'tests'; update testing to 1.17-1.15 (#4708)

commit 0b372df5f45ee5e81aaae18ae9e5ad60eab60586
Author: Menghan Li <[email protected]>
Date:   Thu Aug 26 10:21:09 2021 -0700

    xds/client: NACK ringhash lb policy if env var is not set (#4707)

commit 712e8d4f57fd4a4fbb83406148f9c71eb3e7714e
Author: Easwar Swaminathan <[email protected]>
Date:   Wed Aug 25 14:51:41 2021 -0700

    Remove support for Go 1.13 and older (cont) (#4706)

commit 498743c19e864d45b6761fd0b8c6cf7ad72eb271
Author: apolcyn <[email protected]>
Date:   Wed Aug 25 14:03:53 2021 -0700

    xds/c2p: update default XDS server name in C2P resolver (#4705)

commit 6bd8e8cf30e25b6cde3ec16389ff470680c107b1
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Aug 24 14:24:34 2021 -0700

    multiple: remove support for Go 1.11 (#4700)

commit 5f4bc66745e1af8406741bb329a7bb7119631e02
Author: Doug Fawley <[email protected]>
Date:   Tue Aug 24 13:52:18 2021 -0700

    grpc: fix stayConnected function to connect upon entry (#4699)

    If stayConnected was called while the ClientConn was in IDLE already, it would
    never call Connect, and stay stuck in that state.  This change ensures
    cc.Connect is always called at least once.

commit 46ab723bb20867a29022047224194fefd311cb37
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Aug 24 12:30:13 2021 -0700

    multiple: remove appengine specific build constraints and code (#4685)

commit bfd964bba69658b989ff619c40383e59d13770f1
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Aug 24 11:19:04 2021 -0700

    xds: use the defaultTestTimeout instead of the short one (#4684)

commit dc3afb202f85e5540ece8743b114c7287a5f37a4
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Aug 24 11:04:25 2021 -0700

    xds: deflake Test/ServerSideXDS_ServingModeChanges (#4689)

commit 45a623cbefb83b4708e549616fde9c6d613710ad
Author: Easwar Swaminathan <[email protected]>
Date:   Tue Aug 24 10:02:55 2021 -0700

    test: use non blocking dials in end2end_test (#4687)

commit c361e9ea1646283baf7b23a5d060c45fce9a1dea
Author: Zach Reyes <[email protected]>
Date:   Mon Aug 23 19:39:14 2021 -0400

    Move Server Credentials Handshake to transport (#4692)

    * Move Server Credentials Handshake to transport

commit 8ab16ef276a33df4cdb106446eeff40ff56a6928
Author: Doug Fawley <[email protected]>
Date:   Wed Aug 18 15:04:35 2021 -0700

    balancer: add ExitIdle optional interface (#4673)

commit 52cea2453436fbb4b962d3cb2da34da7ef6f10c7
Author: 吴亲库里 <[email protected]>
Date:   Thu Aug 19 04:31:22 2021 +0800

    server: fix net.conn closed twice (#4663)

commit a42567fe92f005c47e60146bdbb0d5f7fc232219
Author: Menghan Li <[email protected]>
Date:   Thu Aug 12 11:12:02 2021 -0700

    xds: support picking ringhash in xds client and cds policy (#4657)

commit ad87ad009856d3423e067fc49b990d05e16d706c
Author: Zach Reyes <[email protected]>
Date:   Wed Aug 11 18:48:24 2021 -0400

    xds: Add support for Dynamic RDS in listener wrapper (#4655)

    * Add support for Dynamic RDS in listener wrapper

commit 88dc96b463fb9a695e6181750e78524df1903601
Author: Lidi Zheng <[email protected]>
Date:   Wed Aug 11 14:33:44 2021 -0700

    Copy the tag_and_push_docker_image method to grpc-go (#4667)

commit 9c668aeab86903a70e291eb47a04f48d84e67006
Author: Aliaksandr Mianzhynski <[email protected]>
Date:   Wed Aug 11 19:17:59 2021 +0300

    all: preallocate slices where possible (#4609)

commit c7c1e9e0ec7aed0a530cde1e7d2fc7382a6816a2
Author: Lidi Zheng <[email protected]>
Date:   Tue Aug 10 20:31:26 2021 -0700

    Update xDS client/server image per-branch tag after build (#4661)

commit 997ce619eb555b6a481e741afa6390ad3cd80d5c
Author: Doug Fawley <[email protected]>
Date:   Tue Aug 10 13:22:34 2021 -0700

    clientconn: do not automatically reconnect addrConns; go idle instead (#4613)

commit 01bababd83492b6eb1c7046ab4c3a4b1bcc5e9d6
Author: Zach Reyes <[email protected]>
Date:   Mon Aug 9 23:15:57 2021 -0400

    Added connection to transport context (#4649)

    * Added connection to transport context

commit 574137db7de3c10e010d5023626169f13540cef1
Author: Easwar Swaminathan <[email protected]>
Date:   Fri Aug 6 10:56:44 2021 -0700

    xds: fix flaky test (TestPickerUpdateAfterClose) (#4658)

commit fc30d5b571f5981b71e8391a04e23c5f98eab4c3
Author: Menghan Li <[email protected]>
Date:   Thu Aug 5 14:30:04 2021 -0700

    xds/cluster_resolver: support RING_HASH as a child of cluster_resolver balancer (#4621)

    1. merge endpoint picking and localility picking policy to one field in cluster_resolver's balancer config
       - This field only supports ROUND_ROBIN or RING_HASH.
       - This is to support RING_HASH policy, which is responsible both endpoint picking and locality picking.
       - If policy is RING_HASH, endpoints in localities will be flattened to a list of endpoints, and passed to the policy.
    1. support building policy config with RING_HASH as a child
       - The config tree has one less layer comparing with ROUND_ROBIN
       - This also need to define RING_HASH's balancer config config
    1. Deleted test `TestEDS_UpdateSubBalancerName` because now the balancer doesn't support updating child to a custom policy.

commit 74370577fa163f6022fb88a5926192a7c26a3933
Author: Zach Reyes <[email protected]>
Date:   Thu Aug 5 17:28:06 2021 -0400

    xds: Add route to filterchain (#4610)

    * Added RDS Information from LDS in filter chain

commit 6ba56c814be74c95e35a000582e074a380e545b0
Author: Menghan Li <[email protected]>
Date:   Tue Aug 3 15:12:56 2021 -0700

    transport: fix race accessing s.recvCompress (#4645)

    This is a backport of #4641

commit 0d6854ab5ecc205b0f7437919b7988f67144eba9
Author: Menghan Li <[email protected]>
Date:   Tue Aug 3 14:17:02 2021 -0700

    transport: fix race accessing s.recvCompress (#4641)

commit edb9b3bc226676eba6fe1cddec44d082b5a30e4f
Author: Doug Fawley <[email protected]>
Date:   Mon Aug 2 15:56:58 2021 -0700

    github: update stale bot to v4 (#4636)

commit c052940bcd91bba85050ac193aeeca6e1c588e8a
Author: Menghan Li <[email protected]>
Date:   Mon Aug 2 13:05:02 2021 -0700

    server: fix leaked net.Conn (#4633)

    This happens when NewServerTransport() returns nil, nil. The rawConn is
    closed when the transport is closed, which will never happen in this
    case (since the returned transport is nil).

commit 8ed8dd26555f396d81f497415086ec73103e5825
Author: ZhenLian <[email protected]>
Date:   Mon Aug 2 13:03:54 2021 -0700

    advancedtls: fix a typo in crl.go (#4634)

commit ea9b7a0a7651baaf43c5403cb83349fffb5162df
Author: Easwar Swaminathan <[email protected]>
Date:   Thu Jul 29 17:23:32 2021 -0700

    xds: fix a typo (#4631)

commit ad0a2a847cdfb3204c30d1423436fdeec8ff17bf
Author: April Kyle Nassi <[email protected]>
Date:   Wed Jul 28 14:46:46 2021 -0700

    Update MAINTAINERS.md (#4628)

    moved 2 to emeritus list

commit 61c704607b40236f021f3120e5a4b1c237ed8ade
Author: raymonder jin <[email protected]>
Date:   Thu Jul 29 02:02:38 2021 +0800

    fix typo (#4616)

commit 245ad25715e019716d10f5b24d761f85ff158c15
Author: Zach Reyes <[email protected]>
Date:   Tue Jul 27 15:13:18 2021 -0400

    Change version to 1.41.0-dev (#4625)

commit 00edd8c13a7a27bc25c8de2a68cf6de35f88bd7e
Author: Lidi Zheng <[email protected]>
Date:   Mon Jul 26 13:02:56 2021 -0700

    Add xDS k8s url-map test Kokoro job (#4614)

commit 1ddab338690a578975747239ad4ecd2ae63b1965
Author: Doug Fawley <[email protected]>
Date:   Fri Jul 23 10:37:18 2021 -0700

    client: fix detection of whether IO was performed in NewStream (#4611)

    For transparent retry.

    Also allow non-WFR RPCs to retry indefinitely on errors that resulted in no I/O; the spec used to forbid it at one point during development, but it no longer does.

commit 582ef458c6d8174087877ee83bb514abc16650a5
Author: Menghan Li <[email protected]>
Date:   Thu Jul 22 16:12:30 2021 -0700

    cluster_resolver: move balancer config types into cluster_resolver package and unexport (#4607)

commit c513103bee39e1ebc3793e7128941794667779de
Author: Zach Reyes <[email protected]>
Date:   Wed Jul 21 22:42:38 2021 -0400

    Add extra layer on top of RBAC Engine (#4576)

    * Add extra layer in RBAC

commit a0bed723f1c00c8b07c6ceaf1f6ac2cb42ec0b35
Author: Zach Reyes <[email protected]>
Date:   Wed Jul 21 21:58:19 2021 -0400

    xds: add http filters to FilterChain matching (#4595)

    * Add HTTP Filters to FilterChain

commit 0a8c63739a87bee6ff6097d272b63727659f4503
Author: apolcyn <[email protected]>
Date:   Wed Jul 21 10:50:37 2021 -0700

    grpclb: propagate the most recent connection error when grpclb enters transient failure (#4605)

commit 8332d5b997af9e1554418167860351696d35e628
Author: lzhfromustc <[email protected]>
Date:   Wed Jul 21 13:40:04 2021 -0400

    test: fix possible goroutine leaks in unit tests (#4570)

commit 0300770df1c0b742f4eef4cce47ca315379ad4d1
Author: Menghan Li <[email protected]>
Date:   Wed Jul 21 10:22:02 2021 -0700

    xds: support cluster fallback in cluster_resolver (#4594)

commit 65cabd74d8e18d7347fecd414fa8d83a00035f5f
Author: Jille Timmermans <[email protected]>
Date:   Tue Jul 20 19:58:14 2021 +0200

    internal/binarylog: Fix data race when calling Write() and Close() in parallel (#4604)

    They both touched bufferedSink.writeTicker

commit ce7bdf50abb1f7c7a5ba1a54890e6dac46eb87f7
Author: Matt Jones <[email protected]>
Date:   Thu Jul 15 09:53:31 2021 -0700

    advancedtls: CRL checking for golang gRPC (#4489)

    * Code for CRL checking for golang gRPC.

commit 0103ea2d6c98f59ddd6ff09aa93f963936157213
Author: John Howard <[email protected]>
Date:   Wed Jul 14 13:59:50 2021 -0700

    client: improve GOAWAY debug messages (#4587)

commit b586e9215896c69206b29af00f30bc34d483b6fc
Author: Menghan Li <[email protected]>
Date:   Wed Jul 14 13:10:19 2021 -0700

    xds/client: notify the resource watchers of xDS errors (#4564)

commit bfe1d0dc23ac33e7c8ebf125753e5fb0698a4bde
Author: Jille Timmermans <[email protected]>
Date:   Wed Jul 14 20:34:40 2021 +0200

    binarylog: Use a simple boolean rather than a sync.Once (#4581)

commit ba41bbac225e6e1a9b822fe636c40c3b7d977894
Author: James Protzman <[email protected]>
Date:   Wed Jul 14 13:54:58 2021 -0400

    transport: validate http 200 status for responses (#4474)

commit ebfe3be62a82434bc83fd7b36410141a603a96be
Author: Menghan Li <[email protected]>
Date:   Mon Jul 12 16:42:02 2021 -0700

    cluster_resolver: implement resource resolver to resolve EDS and DNS (#4531)

commit 30dfb4b933a50fd366d7ed36ed4f71dbba2d382e
Author: Jille Timmermans <[email protected]>
Date:   Thu Jul 8 19:06:55 2021 +0200

    binarylog: Don't continue after failing to marshal the proto (#4582)

commit 51e780ce00959f0a2ba16ca7c65f3b99a91c3c61
Author: Jille Timmermans <[email protected]>
Date:   Thu Jul 8 19:06:11 2021 +0200

    internal/binarylog: Use defer to unlock mutexes (#4590)

commit afad37618961fd1123d6582661895c6c533852ea
Author: Easwar Swaminathan <[email protected]>
Date:   Thu Jul 8 09:20:15 2021 -0700

    Fix bootstrap format in comment (#4586)

commit 91e0aeb192456225adf27966d04ada4cf8599915
Author: Jille Timmermans <[email protected]>
Date:   Thu Jul 8 01:37:57 2021 +0200

    binarylog: Don't leak the flusher goroutine when closing a Sink (#4583)

    time.Ticker.Stop() doesn't close the ticker channel, so we need to signal the goroutine to die some other way

commit dd589923e1a17f5cc7c667359ae12d56bc1d3113
Author: Doug Fawley <[email protected]>
Date:   Fri Jul 2 16:21:46 2021 -0700

    clientconn: stop automatically connecting to idle subchannels returned by picker (#4579)

commit 52546c5d89b7e362064f2a21c9d10803b44af15f
Author: Ashitha Santhosh <[email protected]>
Date:   Wed Jun 30 11:14:57 2021 -0700

    authorization: translate SDK policy to Envoy RBAC proto (#4523)

    * Translates SDK authorization policy to Envoy RBAC proto.

commit b3f274c2babaeab7802d98e21a66209846437ff5
Author: Menghan Li <[email protected]>
Date:   Tue Jun 29 11:45:16 2021 -0700

    xds/cluster_impl: fix cluster_impl not correctly starting LoadReport stream (#4566)

commit 83f9def5feb388c4fd7e6586bd55cf6bf6d46a01
Author: Vicent Martí <[email protected]>
Date:   Mon Jun 28 18:51:21 2021 +0200

    internal/transport: do not mask ConnectionError (#4561)

commit 9b2fa9f8d3caed4aae28242f6ac7cd27c790806c
Author: Aliaksandr Mianzhynski <[email protected]>
Date:   Fri Jun 25 08:11:47 2021 +0300

    server: improve chained interceptors performance (#4524)

commit e24ede593630782a7718aeb27f116446e0284f90
Author: Menghan Li <[email protected]>
Date:   Thu Jun 24 16:20:11 2021 -0700

    xds: delete LRS policy and move the functionality to xds_cluster_impl (#4528)

    - (cluster_resolver) attach locality ID to addresses
    - (cluster_impl) wrap SubConn
    - (lrs) delete

commit d9eb12feed7a0f45d4acbf478e83171f4c00210a
Author: Doug Fawley <[email protected]>
Date:   Wed Jun 23 14:15:56 2021 -0700

    xdsclient: move tests out of tests directory (#4535)

commit b9270c3a7f163541823e37485aae70fcf043d406
Author: Zach Reyes <[email protected]>
Date:   Wed Jun 23 16:36:24 2021 -0400

    client: add deadline for TransportCredentials handshaker (#4559)

    * Add deadline on connection for TransportCredentials handshake

commit 4440c3b8306d28f4af5833bdf12ac54866dc1423
Author: Menghan Li <[email protected]>
Date:   Tue Jun 22 14:57:05 2021 -0700

    cluster_resolver: fix DiscoveryMechanismType marshal JSON (#4532)

commit 14c7ed60ad7655f522345032f0c0c7ae05303816
Author: Menghan Li <[email protected]>
Date:   Tue Jun 22 11:03:12 2021 -0700

    xds/circuit_breaking: counters should be keyed by {cluster, EDS service name} pair (#4560)

commit 50328cf800a44d78199311c2d93f5856e4b699c1
Author: Sergii Tkachenko <[email protected]>
Date:   Mon Jun 21 15:11:57 2021 -0400

    buildscripts: add option to use xds-k8s test driver from a fork (#4548)

commit 4faa31f0a5809a5064ee128c9d855c0bedc1c783
Author: Iskandarov Lev <[email protected]>
Date:   Fri Jun 18 23:21:07 2021 +0300

    stats: add stream info inside stats.Begin (#4533)

commit 74fe073e9acce820ff3815b78e49aadd10439d59
Author: Doug Fawley <[email protected]>
Date:   Thu Jun 17 16:53:52 2021 -0700

    Revert "xds: require router filter when filters are empty" (#4556)

    This reverts commit 00ae0c57cc0a418f5208906d4f68c4b682dc662c.

commit 1c1e3f88d343d53aa7be5712e21d42d46892bc32
Author: Menghan Li <[email protected]>
Date:   Thu Jun 17 11:29:17 2021 -0700

    xds: fix test race in c