meshca: Don't use the config proto from grpc-proto #4056
Conversation
| echo "git clone ${repo}" | ||
| git clone --quiet ${repo} ${WORKDIR}/${dirname} | ||
| done | ||
|
|
||
| # Pull in the MeshCA service proto. |
There was a problem hiding this comment.
What will it take to do this next? We should really not be generating .pb.gos from protos outside grpc-proto at all.
There was a problem hiding this comment.
Yes, this is a weird case. Ideally, the MeshCA protos should have been part of googleapis or some public repo like that.
When (and if) we have to get this back, we probably might directly depend on the pb.gos from the istio repo. But I'm not sure if that is any better.
There was a problem hiding this comment.
When (and if) we have to get this back, we probably might directly depend on the pb.gos from the istio repo. But I'm not sure if that is any better.
It is better, since it means:
- we don't have to deal with their proto's dependencies, which may expand over time, and
- we don't risk a panic if multiple generated versions of this proto are imported by one program.
We should be actively looking to remove this.
There was a problem hiding this comment.
Filed an issue to track this: #4058
No description provided.