Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: Minor cleanup in client/v2 tests. #3989

Merged
merged 1 commit into from
Oct 28, 2020
Merged

xds: Minor cleanup in client/v2 tests. #3989

merged 1 commit into from
Oct 28, 2020

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 26, 2020

Reduces test run time from ~20s to ~2s.

@easwars
xds: Minor cleanup in client/v2 tests.
ee71308 
Reduces test run time from ~20s to ~2s.
@easwars easwars requested a review from menghanl October 26, 2020 20:12
menghanl
menghanl approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@menghanl
Copy link
Contributor

Travis doesn't know how to count that low

@easwars easwars merged commit 15a78f1 into grpc:master Oct 28, 2020
@easwars easwars deleted the v2_tests branch October 28, 2020 00:29
davidkhala pushed a commit to Hyperledger-TWGC/grpc that referenced this pull request Dec 7, 2020
@easwars @davidkhala
xds: Minor cleanup in client/v2 tests. (grpc#3989)
f969b91
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easwars @menghanl