certprovider-api: api tweaks to read config from bootstrap #3987
Conversation
|
The names are still up for debate and finalizing. The functionality matches what we discussed on the other PR. |
d76d295
to
204f36e
Compare
204f36e
to
575db0e
Compare
575db0e
to
33b2f76
Compare
|
This should be ready for another look. I have updated the CDS balancer and bootstrap code to work with the proposed API. PTAL. Thanks. |
|
Ping ... |
There was a problem hiding this comment.
Looks good overall. Regarding names, I think we can continue to iterate here as needed. It's really unfortunate that this now seems very xds-specific due to splitting the initialization into two arbitrary steps. Ideally this would be a generic TLS addon capability.
| logger.Errorf("sts.NewCredentials() failed: %v", err) | ||
| return nil | ||
| } | ||
| return certprovider.NewBuildableConfig(pluginName, cfg.canonical(), func(opts certprovider.BuildOptions) certprovider.Provider { |
There was a problem hiding this comment.
IMO this is too much code for a closure.
Can this be made a function instead, with parameters for whatever needs to be captured by the closure?
There was a problem hiding this comment.
Ohh, I like how this makes the diffs much nicer as well. 😄
|
|
||
| // NewBuildableConfig creates a new BuildableConfig with the given arguments. | ||
| // Provider implementations are expected to invoke this function after parsing | ||
| // the given JSON configuration as part of their ParseConfig() method. |
| logger.Errorf("sts.NewCredentials() failed: %v", err) | ||
| return nil | ||
| } | ||
| return certprovider.NewBuildableConfig(pluginName, cfg.canonical(), func(opts certprovider.BuildOptions) certprovider.Provider { |
There was a problem hiding this comment.
Ohh, I like how this makes the diffs much nicer as well. 😄
We recently decided to move the plugin configuration to be read and parsed from the bootstrap file instead of receiving it from the control plane. This has necessitated a few changes to the API:
ParseConfig()method will return a concrete type,BuildableConfig.BuildableConfighas aBuild()method which returns instances ofProvider.certprovider.GetProviderwhich contained the store functionality has been removed, and is folded inside the concrete type,BuildableConfig.As part of this PR, the existing MeshCA plugin implementation is also updated to comply with the new API.