Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

certprovider-api: use correct format for "certificate_providers" field #3922

Merged
merged 2 commits into from
Oct 2, 2020

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 2, 2020

The expected format for the certificate_providers field was wrong:

	"certificate_providers" : {
		"default": { 
			"plugin_bar" : {bar plugin config in JSON }
		},
		"foo": {
			"plugin_foo" : { foo plugin config in JSON }
		}
	}

The correct format is:

	"certificate_providers" : {
		"default": {
			"plugin_name": "plugin_bar",
			"config": { default plugin config in JSON }
		},
		"foo": {
			"plugin_name": "plugin_foo",
			"config": { foo plugin config in JSON }
		}
	}

@easwars easwars merged commit d528058 into grpc:master Oct 2, 2020
@easwars easwars deleted the bootsrap_fix branch October 5, 2020 17:12
@easwars easwars changed the title xds/bootstrap: Use correct format for "certificate_providers" field. certprovider-api: use correct format for "certificate_providers" field Mar 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants