doc: update README for supported Go versions and travis for tests #3516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
approved these changes
Apr 10, 2020
chalin
reviewed
Apr 11, 2020
| @@ -29,7 +29,7 @@ If you are trying to access grpc-go from within China, please see the | |||
|
|
|||
| Prerequisites | |||
| ------------- | |||
| gRPC-Go requires Go 1.9 or later. | |||
| gRPC-Go supports the three latest releases of Go. | |||
There was a problem hiding this comment.
It might be a good idea to link "latest releases of Go" to https://golang.org/doc/devel/release.html. Also might you want to qualify the statement with as "officially supports"?
chalin
added a commit
to chalin/grpc-go
that referenced
this pull request
Apr 11, 2020
As mentioned in grpc#3516, "update `.pb.go` file due to changes in Go 1.14's `gofmt` and `go-cmp`
chalin
added a commit
to chalin/grpc-go
that referenced
this pull request
Apr 11, 2020
As mentioned in grpc#3516, "update `.pb.go` file due to changes in Go 1.14's `gofmt` and `go-cmp`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to also update a
pb.gofile due to changes in Go 1.14'sgofmtandgo-cmpto version 0.4 to bring in a bug fix needed by 1.14.