all: refactor .pb.go generation #3451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Apr 23, 2020
|
Resolved the merge conflict. Ran regenerate.sh, which also picked up a minor change to |
Unfortunately, this now triggers a deprecated check, because one of the fields was marked as deprecated. Can you take a look @easwars? |
Replace various //go:generate lines and regenerate.sh scripts with a single, top-level regenerate.sh that regenerates all .pb.go files. Placing generation in a single script ensures that all files are generated with similar parameters. The new regenerate.sh uses the protoc-gen-go version defined in test/tools/go.mod and automatically handles new .proto files as they are added. Do some minor refactoring on .proto files: Every file now has a go_package option (which will be required by a future version of the code generator), and file imports are all relative to the repository root.
|
Rebased to after #3562 . |
dfawley
approved these changes
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace various //go:generate lines and regenerate.sh scripts with a
single, top-level regenerate.sh that regenerates all .pb.go files.
Placing generation in a single script ensures that all files are
generated with similar parameters. The new regenerate.sh uses the
protoc-gen-go version defined in test/tools/go.mod and automatically
handles new .proto files as they are added.
Do some minor refactoring on .proto files: Every file now has a
go_package option (which will be required by a future version of the
code generator), and file imports are all relative to the repository
root.