Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: use generated files from go-control-plane #3083

Merged
merged 4 commits into from
Oct 29, 2019
Merged

xds: use generated files from go-control-plane #3083

merged 4 commits into from
Oct 29, 2019

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Oct 9, 2019

Kept orca because orca pb.go files are not checked in.

@menghanl menghanl added the Type: Internal Cleanup Refactors, etc label Oct 9, 2019
@menghanl menghanl added this to the 1.25 Release milestone Oct 9, 2019
easwars
easwars approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@easwars easwars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YaY !!

@menghanl menghanl force-pushed the xds_proto_update branch 5 times, most recently from b979b08 to 3b5765d Compare October 24, 2019 23:50
@menghanl
Copy link
Contributor Author

This adds go-control-plane as a dependency to grpc module, but not to grpc package.
Experiment (with go1.13) showed that go module doesn't pull in go-control-plane if the user only depends on grpc but not on xds.

@menghanl
[xds_proto_update] remove xds pb.go, but keep orca
c6ed47c 
validate needs to be removed, otherwise build fails due to duplicate
proto type registered.
@menghanl
[xds_proto_update] use go-control-plane for pb.go
420159e
@menghanl
[xds_proto_update] copy and use envoy pb.go from go-control plane
a77548e 
And remove some packages, to avoid go.mod dependencies
@menghanl
Revert "[xds_proto_update] copy and use envoy pb.go from go-control p…
9d8a452 
…lane"

This reverts commit 9dd315d.
@menghanl menghanl merged commit a8f166a into grpc:master Oct 29, 2019
@menghanl menghanl deleted the xds_proto_update branch October 29, 2019 18:14
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@easwars easwars easwars approved these changes

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.25 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @easwars @dfawley