Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpctest: add new package to manage tests and support per-test setup/teardown #2523

Merged
merged 1 commit into from
Jan 7, 2019
Merged

grpctest: add new package to manage tests and support per-test setup/teardown #2523

merged 1 commit into from
Jan 7, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Dec 13, 2018

  • Migrate grpc & grpc/test packages to use Teardown support to guarantee leakcheck is used

@dfawley dfawley force-pushed the testsuite branch 3 times, most recently from 03f2164 to d4b1cb2 Compare December 17, 2018 21:54
menghanl
menghanl approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dfawley dfawley changed the title POC: grpctest: add new package to manage tests and support per-test teardown grpctest: add new package to manage tests and support per-test setup/teardown Jan 7, 2019
@dfawley dfawley merged commit 0a391ff into grpc:master Jan 7, 2019
@dfawley dfawley mentioned this pull request Jan 7, 2019
Closed
@dfawley dfawley deleted the testsuite branch January 8, 2019 17:38
@lock lock bot locked as resolved and limited conversation to collaborators Jul 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfawley @menghanl