Notify parent ClientConn to re-resolve in grpclb #1699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29566fc
to
19f2c3a
Compare
MakMukhi
approved these changes
Dec 13, 2017
balancer/balancer.go
Outdated
| @@ -96,6 +96,9 @@ type ClientConn interface { | |||
| // on the new picker to pick new SubConn. | |||
| UpdateBalancerState(s connectivity.State, p Picker) | |||
|
|
|||
| // ResolveNow is called by balancer to notify gRPC to do a name resolveing. | |||
grpclb_util.go
Outdated
| ccb balancer.ClientConn | ||
| } | ||
|
|
||
| func (r *lbManualResolver) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOption) (resolver.Resolver, error) { |
There was a problem hiding this comment.
Since target and opts are not used in the method, maybe we should not name those parameters?
19f2c3a
to
cd418b6
Compare
menghanl
commented
Dec 15, 2017
balancer/balancer.go
Outdated
| @@ -96,6 +96,9 @@ type ClientConn interface { | |||
| // on the new picker to pick new SubConn. | |||
| UpdateBalancerState(s connectivity.State, p Picker) | |||
|
|
|||
| // ResolveNow is called by balancer to notify gRPC to do a name resolveing. | |||
grpclb_util.go
Outdated
| ccb balancer.ClientConn | ||
| } | ||
|
|
||
| func (r *lbManualResolver) Build(target resolver.Target, cc resolver.ClientConn, opts resolver.BuildOption) (resolver.Resolver, error) { |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent ClientConn should re-resolve when grpclb loses connection to the
remote balancer.
When the
ClientConninside grpclb gets aTransientFailure, it callslbManualResolver.ResolveNow(), which calls parent ClientConn'sResolveNow, andeventually results in re-resolve happening in parent ClientConn's resolver (DNS
for example).
This PR adds a method to
balancer.ClientConninterface, so balancer can tellparent ClientConn to re-resolve.