Responded to Easwar's comments

grpc · Jun 27, 2024 · 291f767 · 291f767
1 parent fdbd01b
commit 291f767
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/examples/features/opentelemetry/client/main.go b/examples/features/opentelemetry/client/main.go
@@ -37,19 +37,17 @@ import (
 )
 
 var (
- addr = flag.String("addr", ":50051", "the server address to connect to")
- promAddr = flag.String("promAddr", ":9465", "the Prometheus exporter endpoint")
+ addr  = flag.String("addr", ":50051", "the server address to connect to")
+ prometheusEndpoint = flag.String("prometheus_endpoint", ":9465", "the Prometheus exporter endpoint")
 )
 
 func main() {
  exporter, err := prometheus.New()
  if err != nil {
  log.Fatalf("Failed to start prometheus exporter: %v", err)
  }
- provider := metric.NewMeterProvider(
- metric.WithReader(exporter),
- )
- go http.ListenAndServe(*promAddr, promhttp.Handler())
+ provider := metric.NewMeterProvider(metric.WithReader(exporter))
+ go http.ListenAndServe(*prometheusEndpoint, promhttp.Handler())
 
  ctx := context.Background()
  do := opentelemetry.DialOption(opentelemetry.Options{MetricsOptions: opentelemetry.MetricsOptions{MeterProvider: provider}})

diff --git a/examples/features/opentelemetry/server/main.go b/examples/features/opentelemetry/server/main.go
@@ -36,8 +36,8 @@ import (
 )
 
 var (
- addr = flag.String("addr", ":50051", "the server address to connect to")
- promAddr = flag.String("promAddr", ":9464", "the Prometheus exporter endpoint")
+ addr  = flag.String("addr", ":50051", "the server address to connect to")
+ prometheusEndpoint = flag.String("prometheus_endpoint", ":9464", "the Prometheus exporter endpoint")
 )
 
 type echoServer struct {
@@ -54,25 +54,21 @@ func main() {
  if err != nil {
  log.Fatalf("Failed to start prometheus exporter: %v", err)
  }
- provider := metric.NewMeterProvider(
- metric.WithReader(exporter),
- )
- go http.ListenAndServe(*promAddr, promhttp.Handler())
+ provider := metric.NewMeterProvider(metric.WithReader(exporter))
+ go http.ListenAndServe(*prometheusEndpoint, promhttp.Handler())
 
  so := opentelemetry.ServerOption(opentelemetry.Options{MetricsOptions: opentelemetry.MetricsOptions{MeterProvider: provider}})
 
  lis, err := net.Listen("tcp", *addr)
  if err != nil {
- log.Fatalf("failed to listen: %v", err)
+ log.Fatalf("Failed to listen: %v", err)
  }
  s := grpc.NewServer(so)
- pb.RegisterEchoServer(s, &echoServer{
- addr: *addr,
- })
+ pb.RegisterEchoServer(s, &echoServer{addr: *addr})
 
- log.Printf("serving on %s\n", *addr)
+ log.Printf("Serving on %s\n", *addr)
 
  if err := s.Serve(lis); err != nil {
- log.Fatalf("failed to serve: %v", err)
+ log.Fatalf("Failed to serve: %v", err)
  }
 }