Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove or skip callbacks on old connections #522

Merged
merged 5 commits into from
Dec 12, 2022
Merged

Remove or skip callbacks on old connections #522

merged 5 commits into from
Dec 12, 2022

Conversation

calmh
Copy link
Contributor

@calmh calmh commented Sep 2, 2021

We are not interested in what happens to it after we recycle it, and we don't want the callback to reset our state to idle just after establishing a new connection.

Fixes #521.

Also fixes a small logic error in abandonConnection.

@calmh
Remove or skip callbacks on old connections
e3aaf87 
We are not interested in what happens to it after we recycle it, and we
don't want the callback to reset our state to idle just after
establishing a new connection.

Fixes grpc#521.

Also fixes a small logic error in abandonConnection.
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 2, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@kevmoo kevmoo requested a review from sigurdm September 13, 2021 17:53
@krjw-eyev krjw-eyev mentioned this pull request Nov 25, 2021
Open
calmh and others added 2 commits March 3, 2022 15:40
@calmh
Merge branch 'master' into fix-521
6b58408 
* master:
  Migrate examples to Dart null safety (grpc#536)
  Remove unnecessary imports and superfluous type checks (grpc#525)
@mraleph
Merge branch 'master' into fix-521
cc793a3
@mraleph mraleph merged commit 4dc6e2b into grpc:master Dec 12, 2022
@gnossen
Copy link

gnossen commented Dec 13, 2022

@mraleph

It looks like this failure is causing the interop tests to fail:

2022-12-12 10:07:21,038 TIMEOUT: cloud_to_prod:dart:default:cancel_after_first_response:tls [pid=75134, time=183.6sec]
2022-12-12 10:07:23,167 WAITING: ETA 0.4 sec; 0 queued, 1 jobs running, 441 complete, 1 failed (load 1.00)
2022-12-12 10:07:33,168 WAITING: ETA 0.5 sec; 0 queued, 1 jobs running, 441 complete, 1 failed (load 1.00)
2022-12-12 10:08:23,170 Passed.

2022-12-12 10:08:23,170 TIMEOUT: cloud_to_prod:dart:gateway_v4:cancel_after_first_response:tls [pid=100719, time=189.0sec]

mraleph added a commit that referenced this pull request Dec 13, 2022
@mraleph
Revert "Remove or skip callbacks on old connections (#522)"
61eb3fb 
This reverts commit 4dc6e2b.
@mraleph mraleph mentioned this pull request Dec 13, 2022
Merged
calmh added a commit to safe-sky/grpc-dart that referenced this pull request Dec 14, 2022
@calmh
Merge branch 'master' into fix-521
1c89211 
* master:
  Revert "Remove or skip callbacks on old connections" (grpc#593)
  Expose client IP address to server (grpc#590)
  Remove or skip callbacks on old connections (grpc#522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraleph mraleph mraleph approved these changes

@sigurdm sigurdm Awaiting requested review from sigurdm

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Open connections grow when connectionTimeout is used
4 participants
@calmh @gnossen @mraleph @kevmoo