-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opentracing middleware: Add Option to put proto request in span for certain methods. #273
Labels
Comments
2 tasks
If this issue is not in development, I can take a stab at it, it would come in handy. |
Oh I see, #277 seems like a it should be resolved before this issue. |
However, pushing entire request in the spawn may cause unnecessarily large amount of data collection. Do you think using field option is a worthy addition?
|
Well it depends on your method. Depends how big requests you have. (or
responses). I would love to have this for certain methods (:
…On Thu, 21 May 2020 at 18:10, Jack Juda ***@***.***> wrote:
However, pushing entire request in the spawn may cause unnecessarily large
amount of data collection. Do you think using field option is a worthy
addition?
`
syntax = "proto3";
import "google/protobuf/descriptor.proto";
package tracing;
extend google.protobuf.FieldOptions {
bool trace = 50000;
}
message MyMessage {
string stuff = 1 [(tracing.trace) = true];
}
`
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#273 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABVA3O63Z6J6JYDCUTIYO2DRSVOA3ANCNFSM4K3JV6IQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
AC:
The text was updated successfully, but these errors were encountered: