Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CCLE Pharmacology Analysis #66

Merged
merged 10 commits into from
Dec 22, 2017

Conversation

gwaybio
Copy link
Collaborator

@gwaybio gwaybio commented Dec 21, 2017

The PR updates the scripts/ras_cell_line_predictions.ipynb notebook to update colors of Figure 3A and adds a processing step of pharmacology data.

The PR also adds an R script scripts/viz/ras_ccle_pharmacology.R to visualize the correlations between Ras classifier score and MEK inhibitor activity in CCLE. All figures are included as well.

@gwaybio gwaybio requested a review from dhimmel December 21, 2017 16:36
Copy link

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trooly astetik

geom_smooth(method = "lm", se = se) +
geom_segment(aes(x = 0.5, y = -0.1, xend = 0.5, yend = 6),
linetype = "dashed", color = "grey") +
scale_color_manual(values = c("#377eb8", "#ff7f00"),
Copy link

@dhimmel dhimmel Dec 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if you should also scale_fill_manual using these same colors but with an alpha of course. May make it easier to differentiate overlapping bands as in selumetinib.pdf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yes, I like that idea.

@gwaybio
Copy link
Collaborator Author

gwaybio commented Dec 22, 2017

Thanks @dhimmel - figures are update (e.g. Selumetinib)

Going to merge!

@gwaybio gwaybio merged commit 39422a3 into greenelab:master Dec 22, 2017
@gwaybio gwaybio deleted the add-ccle-pharm-analysis branch December 22, 2017 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants