[MAINTENANCE] Enable run_id overrides for Checkpoint and ValidationDefinition
#9760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cdkini
commented
Apr 15, 2024
| ) -> ExpectationSuiteValidationResult: | ||
| validator = Validator( | ||
| batch_definition=self.batch_definition, | ||
| batch_parameters=batch_parameters, | ||
| result_format=result_format, | ||
| ) | ||
| results = validator.validate_expectation_suite(self.suite, suite_parameters) | ||
| results.meta["run_id"] = run_id |
There was a problem hiding this comment.
We should never be looking into meta - this should be changed
cdkini
commented
Apr 15, 2024
| @@ -95,7 +95,7 @@ def render( | |||
| ): | |||
| # Gather run identifiers | |||
| run_name, run_time = self._parse_run_values(validation_results) | |||
| expectation_suite_name = validation_results.meta["expectation_suite_name"] | |||
| expectation_suite_name = validation_results.suite_name | |||
There was a problem hiding this comment.
New top level property allows this to be a much safer retrieval
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #9760 +/- ##
===========================================
- Coverage 82.69% 82.68% -0.01%
===========================================
Files 512 512
Lines 46901 46902 +1
===========================================
- Hits 38783 38782 -1
- Misses 8118 8120 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tyler-hoffman
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users should be able to pass a custom
run_idfor validation workflows.PR also contains some misc fixes around metadata to enable proper rendering. Finally, there is an update to the type annotation of
Checkpointto suppress a warning we see in the root validator ofEmailAction(not the best practice but we'll return to resolve this soon).invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!