[MAINTENANCE] Add suite_name to ExpectationSuiteValidationResult
#9677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for niobium-lead-7998 canceled.
|
cdkini
commented
Mar 29, 2024
Comment on lines
+512
to
+514
| success: bool, | ||
| results: list[ExpectationValidationResult], | ||
| suite_name: str, |
There was a problem hiding this comment.
These should be guaranteed fields - what is a result if we don't have results, an origin suite, and a success metric?
cdkini
commented
Mar 29, 2024
| evaluation_parameters = fields.Dict() | ||
| statistics = fields.Dict() | ||
| meta = fields.Dict(allow_none=True) | ||
| id = fields.UUID(required=False, allow_none=True) | ||
| checkpoint_name = fields.String(required=False, allow_none=True) |
There was a problem hiding this comment.
This was wrong - it might be in meta but shouldn't be at the top level
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #9677 +/- ##
===========================================
- Coverage 82.55% 82.54% -0.01%
===========================================
Files 511 511
Lines 46383 46381 -2
===========================================
- Hits 38293 38287 -6
- Misses 8090 8094 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -613,7 +610,7 @@ def get_failed_validation_results( | |||
| ) -> ExpectationSuiteValidationResult: | |||
| validation_results = [result for result in self.results if not result.success] | |||
|
|
|||
| successful_expectations = sum(exp.success for exp in validation_results) | |||
| successful_expectations = sum(exp.success or False for exp in validation_results) | |||
There was a problem hiding this comment.
why is this required? do some ValidationResults have a None value for success?
There was a problem hiding this comment.
yeah we'd need a separate effort to clean up the child ExpectationValidationResult. I'll follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!