Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] Revise OSS Installation and Setup Guidance for SQL Data Sources #9609

Merged
merged 2 commits into from
Mar 12, 2024
Merged

[DOCS] Revise OSS Installation and Setup Guidance for SQL Data Sources #9609

merged 2 commits into from
Mar 12, 2024

Conversation

kwcanuck
Copy link
Contributor

@kwcanuck kwcanuck commented Mar 12, 2024 •
edited by jira bot
Loading

DOC-686 requests a review and edit of the existing content in the SQL databases section of Install Great Expectations with source data system dependencies. This PR implements the necessary edits for 1.0.

Definition of done

  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses ruff format + ruff check)
  • Appropriate tests and docs have been updated

@netlify Netlify
Copy link

netlify bot commented Mar 12, 2024 •
edited
Loading

✅ Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 288faf6
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65f05b594df28300082fd1b5
😎 Deploy Preview https://deploy-preview-9609.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Rachel-Reverie
Rachel-Reverie approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@Rachel-Reverie Rachel-Reverie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kwcanuck kwcanuck added this pull request to the merge queue Mar 12, 2024
Merged via the queue into develop with commit 3ae2dd7 Mar 12, 2024
62 checks passed
@kwcanuck kwcanuck deleted the sql-revision branch March 12, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rachel-Reverie Rachel-Reverie Rachel-Reverie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kwcanuck @Rachel-Reverie