Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINTENANCE] Remove context.get_expectation_suite in favor of factory method #9513

Merged
merged 6 commits into from
Feb 22, 2024

Conversation

cdkini
Copy link
Member

@cdkini cdkini commented Feb 22, 2024

  • Description of PR changes above includes a link to an existing GitHub issue
  • PR title is prefixed with one of: [BUGFIX], [FEATURE], [DOCS], [MAINTENANCE], [CONTRIB]
  • Code is linted - run invoke lint (uses black + ruff)
  • Appropriate tests and docs have been updated

For more information about contributing, see Contribute.

After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!

Copy link

netlify bot commented Feb 22, 2024

Deploy Preview for niobium-lead-7998 ready!

Name Link
🔨 Latest commit 3dea2fe
🔍 Latest deploy log https://app.netlify.com/sites/niobium-lead-7998/deploys/65d7b0ff00c3480008d9aaff
😎 Deploy Preview https://deploy-preview-9513.docs.greatexpectations.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


assert suite_name in str(e.value)


@pytest.mark.cloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@cdkini cdkini added this pull request to the merge queue Feb 22, 2024
Merged via the queue into develop with commit 3090fab Feb 22, 2024
67 checks passed
@cdkini cdkini deleted the m/_/update_suite_crud branch February 22, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants