Skip to content
This repository has been archived by the owner on Apr 23, 2024. It is now read-only.
/ js-client Public archive

Update actions #422

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Update actions #422

merged 1 commit into from
Nov 7, 2023

Conversation

michael-wisely-gravwell
Copy link
Collaborator

This PR addresses no issue.

This PR proposes...

  • updating actions/checkout and actions/setup-node to use more recent releases
  • changing the trigger for npm-publish to release instead of create. We don't want npm publish to run on drafts.

with:
node-version: '16.14.0'
registry-url: https://registry.npmjs.org/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the registry-url is not needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not needed. That field is optional. I'm not sure why it was set before.

Copy link
Contributor

@ashnwade ashnwade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashnwade ashnwade merged commit 290a9bd into dev Nov 7, 2023
6 checks passed
@ashnwade ashnwade deleted the actions-update branch November 7, 2023 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants