Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph model classes #173

Merged
merged 146 commits into from
Jun 10, 2019
Merged

Graph model classes #173

merged 146 commits into from
Jun 10, 2019

Conversation

bdpedigo
Copy link
Collaborator

@bdpedigo bdpedigo commented May 16, 2019

Reference Issues/PRs

Closes #142
Closes #143
Closes #174

What does this implement/fix? Explain your changes.

Adds classes for fitting unweighted graph models to data, including ER, DCER, SBM, DCSBM, and RDPG

Any other comments?

  • Does not support weights
  • There are many ways to estimate communities in the a posteriori SBM and DCSBM. Here, only one is implemented, but we could support more or find which methods are best in the future
  • There are several different ways to model the relationship between degree corrections and community membership in the DCSBM. For now, the degree correction parameters are tied to a simple block, but another model would be to randomly sample a community membership and independently sample a degree correction parameter

@bdpedigo bdpedigo added this to the GraSPy 0.0.3 milestone May 29, 2019
@bdpedigo
Copy link
Collaborator Author

@j1c @hhelm10 ready for review

Copy link
Contributor

@hhelm10 hhelm10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good on first pass, most comments are for naming "issues"

docs/reference/models.rst Outdated Show resolved Hide resolved
docs/reference/models.rst Outdated Show resolved Hide resolved
graspy/models/__init__.py Outdated Show resolved Hide resolved
graspy/models/__init__.py Outdated Show resolved Hide resolved
graspy/models/base.py Outdated Show resolved Hide resolved
graspy/models/er.py Outdated Show resolved Hide resolved
graspy/models/er.py Outdated Show resolved Hide resolved
graspy/models/er.py Outdated Show resolved Hide resolved
graspy/models/er.py Outdated Show resolved Hide resolved
graspy/models/__init__.py Outdated Show resolved Hide resolved
@j1c
Copy link
Collaborator

j1c commented Jun 3, 2019

FYI, this PR also has deleted notebooks. Not sure if that was intentional, but let's be a bit more careful what we add/push to which branch.

@bdpedigo
Copy link
Collaborator Author

bdpedigo commented Jun 3, 2019

Yeah I realized that, I can add notebooks back to this PR but I didn't really see the point in that now

@bdpedigo
Copy link
Collaborator Author

bdpedigo commented Jun 5, 2019

@j1c jovo wants me to just merge this and fix any issues later just cause we need to submit graspy to jmlr. I will probably do that Monday

@bdpedigo bdpedigo merged commit aa7ad67 into master Jun 10, 2019
@bdpedigo
Copy link
Collaborator Author

still open to discussion/improvements on what was merged here since it didn't get a real review

@bdpedigo bdpedigo deleted the graphmodel branch June 10, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API for generating data dcsbm fails on integer data graph model fitting classes
5 participants