-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph model classes #173
Graph model classes #173
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good on first pass, most comments are for naming "issues"
FYI, this PR also has deleted notebooks. Not sure if that was intentional, but let's be a bit more careful what we add/push to which branch. |
Yeah I realized that, I can add notebooks back to this PR but I didn't really see the point in that now |
@j1c jovo wants me to just merge this and fix any issues later just cause we need to submit graspy to jmlr. I will probably do that Monday |
still open to discussion/improvements on what was merged here since it didn't get a real review |
Reference Issues/PRs
Closes #142
Closes #143
Closes #174
What does this implement/fix? Explain your changes.
Adds classes for fitting unweighted graph models to data, including ER, DCER, SBM, DCSBM, and RDPG
Any other comments?