Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: warnings in docs build #383

Merged
merged 3 commits into from
Feb 27, 2023
Merged

fix: warnings in docs build #383

merged 3 commits into from
Feb 27, 2023

Conversation

sabard
Copy link
Collaborator

@sabard sabard commented Feb 15, 2023

Small fixes to docs to eliminate compile warnings.
As of now, the custom sphinx theme does not properly format note blocks. Might be something to take a look at in the future.

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 96.39% // Head: 96.39% // No change to project coverage 👍

Coverage data is based on head (d3997c7) compared to base (e175f87).
Patch has no changes to coverable lines.

❗ Current head d3997c7 differs from pull request most recent head 1f5db2a. Consider uploading reports for the commit 1f5db2a to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #383   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files           9        9           
  Lines         916      916           
=======================================
  Hits          883      883           
  Misses         33       33           
Impacted Files Coverage Δ
graphene_sqlalchemy/types.py 93.45% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sabard sabard force-pushed the fix-docs branch 2 times, most recently from d3997c7 to 1f5db2a Compare February 27, 2023 17:32
erikwrede
erikwrede previously approved these changes Feb 27, 2023
Copy link
Member

@erikwrede erikwrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge once ready

@sabard
Copy link
Collaborator Author

sabard commented Feb 27, 2023

@erikwrede sorry, rebased. mind approving again?

@erikwrede erikwrede merged commit 506f58c into master Feb 27, 2023
@sabard sabard deleted the fix-docs branch February 27, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants