Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: RelationshipLoader should utilize DataLoader from the get_data_loader_impl() function, and not directly from aiodataloader library #362

Merged

Conversation

flipbit03
Copy link
Contributor

No description provided.

…mentation housed inside graphene, if possible (graphene >=3.1.1)
Copy link
Contributor Author

@flipbit03 flipbit03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikwrede Thanks in advance!

graphene_sqlalchemy/batching.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #362 (5b2c075) into master (b3657b0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #362      +/-   ##
==========================================
- Coverage   96.50%   96.50%   -0.01%     
==========================================
  Files           9        9              
  Lines         801      800       -1     
==========================================
- Hits          773      772       -1     
  Misses         28       28              
Impacted Files Coverage Δ
graphene_sqlalchemy/batching.py 95.34% <100.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@erikwrede erikwrede merged commit 0a765a1 into graphql-python:master Sep 13, 2022
@flipbit03 flipbit03 deleted the fix/dataloader_use_new_impl branch September 13, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants