Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Graphene DataLoader in graphene>=3.1.1 #360

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

erikwrede
Copy link
Member

@erikwrede erikwrede commented Sep 5, 2022

Fixes the issues described in graphql-python/graphene#1459

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #360 (9b50502) into master (dfee3e9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   96.37%   96.37%           
=======================================
  Files           9        9           
  Lines         773      773           
=======================================
  Hits          745      745           
  Misses         28       28           
Impacted Files Coverage Δ
graphene_sqlalchemy/utils.py 93.33% <ø> (-0.13%) ⬇️
graphene_sqlalchemy/batching.py 93.75% <100.00%> (+0.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

flipbit03
flipbit03 previously approved these changes Sep 6, 2022
Copy link
Contributor

@flipbit03 flipbit03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔥 Now we need to wait for the merge in graphene to move forward with this. Thank you!

Copy link
Contributor

@flipbit03 flipbit03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: ! 😁

@erikwrede erikwrede merged commit a03a8b1 into graphql-python:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants