-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade github actions versions, default python and dev dependencies #1407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the GH action from pypa/[email protected]
(it's been 3 years) to pypa/gh-action-pypi-publish@release/v1
(the latest v1
) as well. See https://github.com/pypa/gh-action-pypi-publish.
Also probably use 3.10
in lint.yml
as well just for consistency.
@kiendang You are right! Updated the PR and I am on the reset of the points! |
May as well update the other actions to latest versions too, |
Thanks for doing this. I've planned to do this as well since I did the exact same thing for graphql-server recently, but was waiting for #1365 to be merged. |
@kiendang thank you for reviewing this with me! Update: seems to be this https://github.com/graphql-python/graphene-django/blob/c1a22bfd91aa3b298ea8f293b1a9f6ece7a46a8e/.pre-commit-config.yaml#LL2C1-L2C1 |
…raphql-python#1407) * Use Python 3.10 for deployments on PyPi * Update gh-action-pypi-publish version * Update python version * Update checkout and setup-python versions * Upgrade dev dependencies * fromat examples and few files to follow black new version * Upgrade pytest version --------- Co-authored-by: Firas Kafri <[email protected]>
make format
for examples files and migrations to follow the new black version