Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiohttp transport - optional variables and operation name #94

Merged
merged 3 commits into from
Jun 14, 2020
Merged

aiohttp transport - optional variables and operation name #94

merged 3 commits into from
Jun 14, 2020

Conversation

leszekhanusz
Copy link
Collaborator

@leszekhanusz leszekhanusz commented May 25, 2020 •
edited
Loading

@coveralls
Copy link

coveralls commented May 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.005%) to 99.216% when pulling 5b112d3 on leszekhanusz:feature_aiohttp_optional_variables_and_operation_name into b4d8132 on graphql-python:master.

@leszekhanusz leszekhanusz mentioned this pull request May 25, 2020
Closed
mariusnita
mariusnita approved these changes May 25, 2020
View reviewed changes
Copy link

@mariusnita mariusnita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixed #92

KingDarBoja
KingDarBoja approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

By the way, this is more like a refactor than a feature as the behaviour is almost the same but to avoid any unexpected server crash as requested at #92.

@leszekhanusz leszekhanusz changed the title Feature aiohttp optional variables and operation name Refactor aiohttp transport - optional variables and operation name May 26, 2020
@leszekhanusz leszekhanusz changed the title Refactor aiohttp transport - optional variables and operation name aiohttp transport - optional variables and operation name May 26, 2020
@leszekhanusz
Copy link
Collaborator Author

By the way, this is more like a refactor than a feature as the behaviour is almost the same but to avoid any unexpected server crash as requested at #92.

Indeed. I removed "Feature" from the title

@leszekhanusz leszekhanusz mentioned this pull request Jun 6, 2020
Closed
@leszekhanusz leszekhanusz merged commit 2849c33 into graphql-python:master Jun 14, 2020
@KingDarBoja KingDarBoja added type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests labels Jun 14, 2020
@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 14, 2020
@leszekhanusz leszekhanusz deleted the feature_aiohttp_optional_variables_and_operation_name branch July 10, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariusnita mariusnita mariusnita approved these changes

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@leszekhanusz @coveralls @mariusnita @KingDarBoja