Fix missing caching. #11
Conversation
|
What I'm curious about is: isn't the old writing style equivalent to the new writing style. What situation led to the necessity of this modification ? But I believe you have your point. If possible, please share it with me. |
| @@ -35,8 +35,10 @@ class PersistenceDecorator extends ForceDecorator { | |||
| void compute(Vertex v, Graph graph) { | |||
| super.compute(v, graph); | |||
| Vertex? cachedVertex = _positionMap[v]; | |||
| if (cachedVertex == null || cachedVertex.position != v.position) { | |||
| if (cachedVertex == null || cachedVertex.position.x != v.position.x || cachedVertex.position.y != v.position.y ) { | |||
There was a problem hiding this comment.
Can you run "dart format ." and resubmit it again? If possible.
There is a formatting issue here.
|
Let me go back to the code - I messed around with my own code and might have to go for a different solution. The whole caching thing is aimed to persist the graph layout e.g. in a json file. What I am struggling at the moment is to find an elegant way to write the data from the json file back via the onLoad function without it being instantaneously overwritten by the compute function. ;-) Will get back to you on the PR. |
The decorator was not updating the cache. This improves performance and enables persistence of the state between sessions.