Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix link issues #1094

Merged
merged 7 commits into from
Jul 16, 2024
Merged

Fix link issues #1094

merged 7 commits into from
Jul 16, 2024

Conversation

KnorpelSenf
Copy link
Member

No description provided.

@KnorpelSenf KnorpelSenf added typo Spelling error or other small mistake not translatable Translator intervention is not required. chore Modifies or is related to tooling, configuration, or setup. labels Jul 16, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

🚀 Deployed on https://6696d27be97f8996afe2c2a1--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request July 16, 2024 08:39 Inactive
@KnorpelSenf
Copy link
Member Author

The tool apparently still reports an error on https://www.scaleway.com/en/pricing/serverless/ (even locally) but this seems to be a problem with the link checker. When I fetch the URL from the Deno CLI or via curl manually, then I can inspect the output just fine.

@rojvv rojvv changed the title Fix all links Fix link issues Jul 16, 2024
@github-actions github-actions bot temporarily deployed to pull request July 16, 2024 11:00 Inactive
@KnorpelSenf
Copy link
Member Author

The link checker issue was fixed. Since we never bothered to pin the version of that tool, it should just work now. @rojvv perhaps we could now also make it a required check for all PQs?

I'll look into making link checking faster by fixing strom in the future. That should bring down CI times by a lot.

@github-actions github-actions bot temporarily deployed to pull request July 16, 2024 19:48 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 16, 2024 20:06 Inactive
@KnorpelSenf
Copy link
Member Author

@rojvv OMG CI PASSED WITH ALL LINKS CHECKED MERGE NOW BEFORE IT IS TOO LATE THIS IS THE FIRST TIME IN YEARS WE WILL STILL OUR GRANDCHILDREN ABOUT THIS DAY NOW DO NOT LOSE TIME

@rojvv rojvv added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit 2dd2a02 Jul 16, 2024
6 checks passed
@rojvv rojvv deleted the fix-links branch July 16, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojvv rojvv rojvv approved these changes

@dcdunkan dcdunkan Awaiting requested review from dcdunkan

Assignees
No one assigned
Labels
chore Modifies or is related to tooling, configuration, or setup. not translatable Translator intervention is not required. typo Spelling error or other small mistake
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KnorpelSenf @rojvv