Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zeabur Doc #1082

Merged
merged 11 commits into from
Jun 29, 2024
Merged

Fix Zeabur Doc #1082

merged 11 commits into from
Jun 29, 2024

Conversation

quadratz
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 19, 2024 •
edited
Loading

🚀 Deployed on https://66808929c64fca6309727ab3--grammy.netlify.app

@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 07:58 Inactive
@quadratz quadratz marked this pull request as ready for review June 19, 2024 08:00
KnorpelSenf
KnorpelSenf approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one.

@KnorpelSenf
Copy link
Member

Why is pnpm used anyway?

@quadratz
Copy link
Contributor Author

Why is pnpm used anyway?

👀 Asking the same question

@KnorpelSenf
Copy link
Member

Why is pnpm used anyway?

👀 Asking the same question

Should we maybe use the opportunity and migrate it to more standard tooling (npm)?

@quadratz
Copy link
Contributor Author

No problem

quadratz
quadratz commented Jun 19, 2024
View reviewed changes
Copy link
Contributor Author

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use npm

site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
site/docs/hosting/zeabur-nodejs.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 19, 2024 12:50 Inactive
KnorpelSenf
KnorpelSenf approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much

@KnorpelSenf KnorpelSenf requested a review from rojvv June 20, 2024 11:05
@KnorpelSenf
Copy link
Member

We might actually be able to sync this to all languages without going through the translation process

@rojvv rojvv added the ready for translation Translator intervention is required. label Jun 20, 2024
@niusia-ua niusia-ua added the 🇺🇦 UK Modifies or is related to the Ukrainian translations. label Jun 21, 2024
@github-actions github-actions bot temporarily deployed to pull request June 21, 2024 06:53 Inactive
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label Jun 22, 2024
@github-actions github-actions bot temporarily deployed to pull request June 22, 2024 13:15 Inactive
@ghost ghost self-assigned this Jun 22, 2024
DzikrL added 2 commits June 22, 2024 23:24
Sync to Indonesian
467bd00 
Zeabur Node.js
Sync to Indonesian
4410e77 
Zeabur Deno
@github-actions github-actions bot temporarily deployed to pull request June 22, 2024 16:27 Inactive
@ghost
Copy link

ghost commented Jun 22, 2024

request review, @quadratz

quadratz
quadratz commented Jun 23, 2024
View reviewed changes
Copy link
Contributor Author

@quadratz quadratz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ID LGTM!

@quadratz quadratz added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label Jun 23, 2024
@github-actions github-actions bot temporarily deployed to pull request June 28, 2024 23:15 Inactive
@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 29, 2024
@github-actions github-actions bot temporarily deployed to pull request June 29, 2024 21:08 Inactive
@KnorpelSenf KnorpelSenf added this pull request to the merge queue Jun 29, 2024
Merged via the queue into main with commit 2a08d67 Jun 29, 2024
5 checks passed
@KnorpelSenf KnorpelSenf deleted the fix-zeabur-doc branch June 29, 2024 22:21
@github-actions github-actions bot temporarily deployed to pull request June 29, 2024 22:23 Inactive
@ghost ghost removed their assignment Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

@habemuscode habemuscode habemuscode approved these changes

@rojvv rojvv rojvv approved these changes

Assignees
No one assigned
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@quadratz @KnorpelSenf @habemuscode @rojvv @niusia-ua @grammyz