Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update i18n docs with information about Unicode isolation marks (#1053) #1058

Merged
merged 12 commits into from
Jun 1, 2024

Conversation

KnorpelSenf
Copy link
Member

Supersedes #1053.

@KnorpelSenf KnorpelSenf requested a review from rojvv May 21, 2024 15:02
@KnorpelSenf KnorpelSenf added ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations. labels May 21, 2024
@KnorpelSenf KnorpelSenf requested a review from quadratz May 21, 2024 15:04
Copy link

github-actions bot commented May 21, 2024

@github-actions github-actions bot temporarily deployed to pull request May 21, 2024 15:06 Inactive
@grammyz grammyz added the 🇨🇳 ZH Modifies or is related to the Chinese translations. label May 21, 2024
@github-actions github-actions bot temporarily deployed to pull request May 21, 2024 15:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 23, 2024 02:12 Inactive
@quadratz quadratz requested a review from a user May 23, 2024 02:23
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@github-actions github-actions bot temporarily deployed to pull request May 24, 2024 11:15 Inactive
@quadratz quadratz added the 🇮🇩 ID Modifies or is related to the Indonesian translations. label May 24, 2024
Copy link
Member

@dcdunkan dcdunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link only seem to have been added to the Indonesian translation.

https://github.com/projectfluent/fluent.js/wiki/Unicode-Isolation

@quadratz
Copy link
Contributor

Yes, that's intentional (#1053 (comment)). Should I remove them?

@dcdunkan
Copy link
Member

Yes, that's intentional (#1053 (comment)). Should I remove them?

I think we should keep it as it'll be useful for the readers.

@habemuscode habemuscode added the 🇪🇸 ES Modifies or is related to the Spanish translations. label Jun 1, 2024
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 15:59 Inactive
@rojvv rojvv changed the title Update i18n.md with information about Unicode isolation marks Update i18n.md with information about Unicode isolation marks (#1053) Jun 1, 2024
@rojvv rojvv changed the title Update i18n.md with information about Unicode isolation marks (#1053) Update i18n docs with information about Unicode isolation marks (#1053) Jun 1, 2024
@rojvv rojvv added this pull request to the merge queue Jun 1, 2024
Merged via the queue into main with commit 1f87a1c Jun 1, 2024
5 checks passed
@rojvv rojvv deleted the unicode-isolation branch June 1, 2024 17:01
@github-actions github-actions bot temporarily deployed to pull request June 1, 2024 17:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇨🇳 ZH Modifies or is related to the Chinese translations. 🇪🇸 ES Modifies or is related to the Spanish translations. 🇮🇩 ID Modifies or is related to the Indonesian translations. ready for translation Translator intervention is required. 🇺🇦 UK Modifies or is related to the Ukrainian translations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants