Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make ctx.i18n non-enumerable #33

Merged
merged 1 commit into from
Jan 29, 2023

Conversation

deptyped
Copy link
Member

Make ctx.i18n non-enumerable to exclude from serialisation in conversations, as discussed in
https://t.me/grammyjs/107171

@deptyped
Copy link
Member Author

Seems like CI failed due to type-error in dcdunkan/tests. @dcdunkan can you take a look?

@rojvv
Copy link
Member

rojvv commented Jan 29, 2023

@deptyped Merge grammyjs:main.

@deptyped deptyped force-pushed the deptyped/conversation-serialisation branch from e164147 to 7d276cf Compare January 29, 2023 16:44
@rojvv rojvv requested a review from dcdunkan January 29, 2023 17:54
Copy link
Member

@dcdunkan dcdunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KnorpelSenf KnorpelSenf changed the title Make ctx.i18n non-enumerable fix: make ctx.i18n non-enumerable Jan 29, 2023
@KnorpelSenf KnorpelSenf merged commit 5297fde into main Jan 29, 2023
@KnorpelSenf KnorpelSenf deleted the deptyped/conversation-serialisation branch January 29, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants