Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on restricted node engine version to choose between esm or cjs #6

Merged
merged 2 commits into from
May 28, 2021

Conversation

KnightNiwrem
Copy link
Contributor

No description provided.

@KnightNiwrem KnightNiwrem changed the title Define .mjs extension as package.json module assumes cjs Define .mjs extension as grammy's package.json module assumes cjs May 27, 2021
@KnightNiwrem KnightNiwrem changed the title Define .mjs extension as grammy's package.json module assumes cjs Rely on (already-in-place) restricted node engine version to choose between esm or cjs May 28, 2021
@KnorpelSenf
Copy link
Member

Tested with Node 12.20 and 14.13 and works. LGTM, thank you so much for investigating and fixing this!

@all-contributors add @KnightNiwrem for coding and finding the bug and also for the throttler plugin

@allcontributors
Copy link
Contributor

@KnorpelSenf

I've put up a pull request to add @KnightNiwrem! 🎉

@KnorpelSenf KnorpelSenf changed the title Rely on (already-in-place) restricted node engine version to choose between esm or cjs Rely on restricted node engine version to choose between esm or cjs May 28, 2021
@KnorpelSenf KnorpelSenf merged commit 5d409e3 into grammyjs:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants