Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow cloning Api instances #594

Merged
merged 6 commits into from
Jun 3, 2024
Merged

feat: allow cloning Api instances #594

merged 6 commits into from
Jun 3, 2024

Conversation

KnorpelSenf
Copy link
Member

This exposes api.token and api.options. This is useful because it lets us create new Api instances from existing ones, optionally reconfiguring them on the fly.

The main use case for this is the second major version of the conversations plugin which no longer shares the same Api instance across context objects—something that was a big hack that mostly worked for v1.

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.75%. Comparing base (d62a142) to head (ec542b5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   47.74%   47.75%   +0.01%     
==========================================
  Files          19       19              
  Lines        6177     6179       +2     
  Branches      343      343              
==========================================
+ Hits         2949     2951       +2     
  Misses       3224     3224              
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KnorpelSenf KnorpelSenf merged commit 9fbf2a1 into main Jun 3, 2024
8 checks passed
@KnorpelSenf KnorpelSenf deleted the clone-api branch June 3, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants