Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly define the subpath ./types in exports #517

Merged
merged 3 commits into from
Jan 1, 2024

Conversation

Satont
Copy link
Member

@Satont Satont commented Jan 1, 2024

Should fix

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './types' is not defined by "exports"

Copy link

codecov bot commented Jan 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c625cb) 46.05% compared to head (f0efb01) 46.05%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #517   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          19       19           
  Lines        6051     6051           
  Branches      266      266           
=======================================
  Hits         2787     2787           
  Misses       3261     3261           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rojvv rojvv changed the title fix: correct types subexport fix: properly define subpath ./types in exports Jan 1, 2024
@rojvv rojvv changed the title fix: properly define subpath ./types in exports fix: properly define the subpath ./types in exports Jan 1, 2024
package.json Outdated Show resolved Hide resolved
@KnorpelSenf
Copy link
Member

This PQ made me remember what is going on. Thanks!

We should only allow type imports via /types. This PQ is not going in the right direction.

Instead, the plugin needs to be fixed. It crashes because it uses export * from while it should only use export type * from. grammyjs/hydrate#25 Fixes that.

@KnorpelSenf KnorpelSenf merged commit 1d8b118 into grammyjs:main Jan 1, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants