Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve export for debug #497

Merged
merged 3 commits into from
Oct 22, 2023
Merged

Improve export for debug #497

merged 3 commits into from
Oct 22, 2023

Conversation

Loskir
Copy link
Contributor

@Loskir Loskir commented Oct 22, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 22, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (84e3ee5) 46.24% compared to head (3aa2d2b) 46.24%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #497   +/-   ##
=======================================
  Coverage   46.24%   46.24%           
=======================================
  Files          19       19           
  Lines        5650     5650           
  Branches      227      227           
=======================================
  Hits         2613     2613           
  Misses       3034     3034           
  Partials        3        3
Files Coverage Δ
src/platform.deno.ts 91.30% <80.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

KnorpelSenf
KnorpelSenf reviewed Oct 22, 2023
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generally try to keep .node.ts and .deno.ts consistent with each other, what does this PQ improve?

KnorpelSenf
KnorpelSenf approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm okay whatever lol

@KnorpelSenf KnorpelSenf merged commit 1c238c0 into main Oct 22, 2023
8 checks passed
@KnorpelSenf KnorpelSenf deleted the Loskir-patch-1 branch October 22, 2023 20:05
@KnorpelSenf
Copy link
Member

Still don't see the benefit haha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Loskir @KnorpelSenf