-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Deno formatter instead of Prettier & reformat #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a config file to restore 4-space indentation, single-quotes, and no-semi?
I said we should use deno fmt
for .md
before I knew how horrible the formatting is. git diff
ing markdown changes is impossible unless we stick with one sentence per line as we've done so far.
Please revert this part of the changes.
I must correct myself! We could try adding config for markdown that does respects our choice of wrapping |
Let's go! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please adjust the CI config to use the config file.
You will also have to update the regex in the backporting script, so that imports are rewritten with double quotes again.
I like the idea of using |
@KnorpelSenf done! |
btw: force pushs make it hard to review changes. All the changes have to be reviewed again. As "Squash and merge" exists its (at least for me) better to just add commits and squash them in the end. It wont clutter the git history that way and is easier to review. |
It seems like there is a bug in I will do some refactoring to work around the problem. Then I can also fix the CI config and change the backporting script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions!
@rojserbest @EdJoPaTo could you have a look again?
Also confer denoland/deno#12452 regarding the bug in |
@all-contributors add @rojserbest for infra |
I've put up a pull request to add @rojserbest! 🎉 |
No description provided.