Use Deno formatter instead of Prettier & reformat

[rojvv]

No description provided.

[KnorpelSenf]

Could you add a config file to restore 4-space indentation, single-quotes, and no-semi?

I said we should use deno fmt for .md before I knew how horrible the formatting is. git diffing markdown changes is impossible unless we stick with one sentence per line as we've done so far.

Please revert this part of the changes.

[KnorpelSenf]

I must correct myself! We could try adding config for markdown that does respects our choice of wrapping

[rojvv]

Let's go!

[KnorpelSenf]

Please adjust the CI config to use the config file.

You will also have to update the regex in the backporting script, so that imports are rewritten with double quotes again.

[EdJoPaTo]

I like the idea of using deno fmt over npm tools but it had some horrible side effects like the Markdown formatting mentioned so I stopped that idea. I'm curious to see what comes out of this.
Also xo (eslint config) seems to have some helpful hints deno lint sadly don't seem to have yet. Otherwise I would like to switch as the deno variants are way less bloated and significantly faster.

[rojvv]

@KnorpelSenf done!

[EdJoPaTo]

btw: force pushs make it hard to review changes. All the changes have to be reviewed again. As "Squash and merge" exists its (at least for me) better to just add commits and squash them in the end. It wont clutter the git history that way and is easier to review.

[KnorpelSenf]

It seems like there is a bug in deno fmt. It cannot handle the comma operator used in lazy sessions. It removes the surrounding brackets, hence changing runtime behaviour. Luckily, this was caught by the code not compiling anymore.

I will do some refactoring to work around the problem. Then I can also fix the CI config and change the backporting script.

[KnorpelSenf]

Thanks for the contributions!

@rojserbest @EdJoPaTo could you have a look again?

[KnorpelSenf]

Also confer denoland/deno#12452 regarding the bug in deno fmt that I was referring to. EDIT: A fix was released in Deno 1.15.2.

[KnorpelSenf]

@all-contributors add @rojserbest for infra

[allcontributors]

@KnorpelSenf

I've put up a pull request to add @rojserbest! 🎉