feat: prevent incorrect signal usage #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 46.51% 46.31% -0.21%
==========================================
Files 19 19
Lines 5615 5640 +25
Branches 226 227 +1
==========================================
Hits 2612 2612
- Misses 3000 3025 +25
Partials 3 3
☔ View full report in Codecov by Sentry. |
KnightNiwrem
approved these changes
Sep 25, 2023
roziscoding
approved these changes
Sep 25, 2023
| you may want to use a method on 'ctx.api' instead. | ||
|
|
||
| If you want to prevent such mistakes in the future, \ | ||
| consider using TypeScript. https://www.typescriptlang.org/`, |
There was a problem hiding this comment.
I hope it will help someone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In https://t.me/grammyjs/168114 and so many other times, people who do not use TS (and who do not read docs) use the context shortcuts and other methods incorrectly. This PQ attempt to explain to them how to fix their code.