Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix some eslint hints #480

Merged
merged 6 commits into from
Aug 29, 2023
Merged

refactor: fix some eslint hints #480

merged 6 commits into from
Aug 29, 2023

Conversation

EdJoPaTo
Copy link
Member

I ran xo on this repo and fixed some lints that came up.

@EdJoPaTo EdJoPaTo changed the title Fix some eslint hints refactor: fix some eslint hints Aug 28, 2023
@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 66.66% and no project coverage change.

Comparison is base (ed71c1f) 46.42% compared to head (be3d618) 46.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   46.42%   46.42%           
=======================================
  Files          19       19           
  Lines        5613     5613           
  Branches      222      222           
=======================================
  Hits         2606     2606           
+ Misses       3005     3004    -1     
- Partials        2        3    +1     
Files Changed Coverage Δ
src/context.ts 23.91% <0.00%> (ø)
src/convenience/session.ts 96.79% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/error.ts Outdated Show resolved Hide resolved
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! <3

@KnorpelSenf
Copy link
Member

Remember to sign your commits. I will overrule now and merge anyway.

@KnorpelSenf KnorpelSenf merged commit 91dfd2f into main Aug 29, 2023
8 checks passed
@KnorpelSenf KnorpelSenf deleted the eslint-xo-hints branch August 29, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants