Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: reformat contributors section #459

Merged
merged 10 commits into from
Jul 1, 2023
Merged

docs: reformat contributors section #459

merged 10 commits into from
Jul 1, 2023

Conversation

KnorpelSenf
Copy link
Member

@KnorpelSenf KnorpelSenf commented Jul 1, 2023

Let's test a new layout. Review https://github.com/grammyjs/grammY/blob/compact-contribs/README.md.

Also, I did a podcast.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ab7b31) 46.55% compared to head (0d2899b) 46.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   46.55%   46.55%           
=======================================
  Files          19       19           
  Lines        5595     5595           
  Branches      222      222           
=======================================
  Hits         2605     2605           
  Misses       2988     2988           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnorpelSenf KnorpelSenf requested a review from rojvv July 1, 2023 19:20
@KnorpelSenf KnorpelSenf marked this pull request as ready for review July 1, 2023 19:20
@KnorpelSenf
Copy link
Member Author

Is this any good?

Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What about replacing the last lines with

This project follows [all-contributors](https://github.com/all-contributors/all-contributors). 
Contributions of any kind are welcome!

?

@KnorpelSenf
Copy link
Member Author

Great idea. Fixed that.

@KnorpelSenf KnorpelSenf merged commit c9c4a90 into main Jul 1, 2023
8 checks passed
@KnorpelSenf KnorpelSenf deleted the compact-contribs branch July 1, 2023 19:34
@KnorpelSenf
Copy link
Member Author

Never seen a 120 lines docs change that was that easy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants