Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README #455

Merged
merged 4 commits into from
Jul 1, 2023
Merged

docs: update README #455

merged 4 commits into from
Jul 1, 2023

Conversation

rojvv
Copy link
Member

@rojvv rojvv commented Jun 29, 2023

No description provided.

@rojvv rojvv added the documentation Improvements or additions to documentation label Jun 29, 2023
@rojvv rojvv requested a review from KnorpelSenf June 29, 2023 18:28
@rojvv
Copy link
Member Author

rojvv commented Jun 29, 2023

Which one is correct?

  • grammY API reference
  • grammY API Reference

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2002f4a) 46.55% compared to head (81f4162) 46.55%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #455   +/-   ##
=======================================
  Coverage   46.55%   46.55%           
=======================================
  Files          19       19           
  Lines        5595     5595           
  Branches      222      222           
=======================================
  Hits         2605     2605           
  Misses       2988     2988           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnorpelSenf
Copy link
Member

Which one is correct?

  • grammY API reference
  • grammY API Reference

I have no idea.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was waiting for this lol, would've done it myself in a few days

@KnorpelSenf
Copy link
Member

grammY api reference hides away

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use grammY API reference as we do here.

@rojvv rojvv requested a review from KnorpelSenf June 30, 2023 19:18
README.md Outdated
We are also [on Twitter](https://twitter.com/grammy_js).

### [Telegram Bot API Reference](https://core.telegram.org/bots/api)
### [Telegram Bot API reference](https://core.telegram.org/bots/api)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you're using grammY style for TG stuff. Shouldn't it be title case? Yes, we will then have two different casings of the same word

@rojvv
Copy link
Member Author

rojvv commented Jun 30, 2023

I modified the wrong line.

@rojvv rojvv requested a review from KnorpelSenf June 30, 2023 20:15
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KnorpelSenf KnorpelSenf merged commit d543639 into main Jul 1, 2023
8 checks passed
@KnorpelSenf KnorpelSenf deleted the roj1512-patch-1 branch July 1, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants