Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add API_CONSTANTS #423

Merged
merged 3 commits into from
Jun 25, 2023
Merged

feat: add API_CONSTANTS #423

merged 3 commits into from
Jun 25, 2023

Conversation

KnorpelSenf
Copy link
Member

Adds useful constants.

Depends on #422 being merged first.

@KnorpelSenf KnorpelSenf requested a review from deptyped May 31, 2023 15:42
@KnorpelSenf KnorpelSenf added this to In progress in Coding via automation May 31, 2023
Coding automation moved this from In progress to Reviewer approved Jun 1, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (6bde720) 41.38% compared to head (73e6d10) 41.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #423      +/-   ##
==========================================
+ Coverage   41.38%   41.73%   +0.35%     
==========================================
  Files          16       17       +1     
  Lines        5082     5113      +31     
  Branches      204      204              
==========================================
+ Hits         2103     2134      +31     
  Misses       2977     2977              
  Partials        2        2              
Impacted Files Coverage Δ
src/convenience/constants.ts 100.00% <100.00%> (ø)
src/mod.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnorpelSenf KnorpelSenf merged commit cc32fe2 into main Jun 25, 2023
8 checks passed
@KnorpelSenf KnorpelSenf deleted the constants branch June 25, 2023 22:27
KnorpelSenf added a commit to ssistoza/grammY that referenced this pull request Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Coding
Reviewer approved
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants