feat: support supplier functions for input files #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
==========================================
+ Coverage 41.73% 41.79% +0.05%
==========================================
Files 17 17
Lines 5113 5118 +5
Branches 204 205 +1
==========================================
+ Hits 2134 2139 +5
Misses 2977 2977
Partials 2 2
☔ View full report in Codecov by Sentry. |
rojvv
reviewed
May 31, 2023
wojpawlik
approved these changes
Jun 2, 2023
|
I need to add tests |
rojvv
approved these changes
Jun 2, 2023
wojpawlik
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only allows
new InputFile(X)but alsonew InputFile(() => X).This is very useful if we need to fetch the data from some place before it can be sent. Currently, API requests cannot be repeated by the auto-retry plugin if they send response streams or file streams. We are effectively limited to the things that
InputFilecan fetch itself internally. This PQ liberates us from that, so we support arbitrary data sources for retries.Closes #106.