test: add tests for composer.ts #400
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #400 +/- ##
==========================================
+ Coverage 35.66% 39.03% +3.36%
==========================================
Files 16 16
Lines 4809 4809
Branches 178 194 +16
==========================================
+ Hits 1715 1877 +162
+ Misses 3093 2930 -163
- Partials 1 2 +1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Need to investigate why CI fails. |
node-fetch types were recently updated to add a non-standard required property called `reson` to the AbortSignal type. to work around this, we cast the AbortSignal to `any` before passing it to fetch
| @@ -26,9 +26,9 @@ | |||
| "devDependencies": { | |||
| "@types/debug": "^4.1.7", | |||
| "@types/node": "^12.20.55", | |||
| "@types/node-fetch": "^2.6.2", | |||
| "@types/node-fetch": "2.6.2", | |||
There was a problem hiding this comment.
Why is the requirement changed for the types but not for the dependency itself? Shouldn’t be both or neither changed?
There was a problem hiding this comment.
No. The types are broken so we pin them for us until they're fixed. That doesn't mean we cannot permit library users to use newer versions.
Tests matter