Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: discontinue CDN builds #393

Merged
merged 4 commits into from
Mar 11, 2023
Merged

build: discontinue CDN builds #393

merged 4 commits into from
Mar 11, 2023

Conversation

KnorpelSenf
Copy link
Member

They started failing because we had to pin the Deno version to 1.21 and we want to use TS features introduced after that. No one is actually using the CDN, so we might as well stop uploading new versions. The old ones will stay there for a while (until next major).

Instead, people can use https://bundle.deno.dev which appeared in the meantime and does the same thing.

This PQ

  • removes the bundling infra
  • removes the CI setup
  • updates the docs in the README

Note that the web builds at grammy/web remain unaffected, as they do not rely on deprecated APIs. In fact, this PQ updates the tooling for them, too.

@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5c77a00) 35.10% compared to head (8d3e4ac) 35.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #393   +/-   ##
=======================================
  Coverage   35.10%   35.10%           
=======================================
  Files          16       16           
  Lines        4785     4785           
  Branches      168      168           
=======================================
  Hits         1680     1680           
  Misses       3103     3103           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@KnorpelSenf KnorpelSenf merged commit f33f23c into main Mar 11, 2023
@KnorpelSenf KnorpelSenf deleted the no-cdn branch March 11, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants