fix: guess correct file name when editing media #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 35.14% 35.10% -0.04%
==========================================
Files 16 16
Lines 4778 4785 +7
Branches 166 168 +2
==========================================
+ Hits 1679 1680 +1
- Misses 3097 3103 +6
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
roziscoding
approved these changes
Mar 11, 2023
|
@all-contributors add @shevernitskiy for this review |
|
I've put up a pull request to add @shevernitskiy! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When guessing a filename, no longer rely on the top-level property that contains the
InputFileinstance. Instead, directly look at the key behind which theInputFileinstance is stored, however deep that may be. Also, if we are insideInputMedia*, use the media type instead. Also also, improve the list of known keys so that we get better at guess them.Fixes #317.