Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exponential backoff for retries and permit cancelling bot.init #377

Merged
merged 4 commits into from
Mar 9, 2023

Conversation

KnorpelSenf
Copy link
Member

Makes sure that bot.init does not retry too fast.

Allows passing an AbortSignal to bot.init so the initialization process can be cancelled anytime.

Makes sure that calling bot.stop will abort any pending initialization.

Makes sure that polling does not start if the bot is stopped while the onStart callback is running.

Closes #291.

@KnorpelSenf KnorpelSenf added this to In progress in Coding via automation Mar 9, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.35 ⚠️

Comparison is base (59c5379) 36.65% compared to head (5938a95) 36.31%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #377      +/-   ##
==========================================
- Coverage   36.65%   36.31%   -0.35%     
==========================================
  Files          18       18              
  Lines        4602     4646      +44     
  Branches      166      166              
==========================================
  Hits         1687     1687              
- Misses       2913     2957      +44     
  Partials        2        2              
Impacted Files Coverage Δ
src/bot.ts 15.45% <0.00%> (-2.50%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Coding automation moved this from In progress to Reviewer approved Mar 9, 2023
@KnorpelSenf KnorpelSenf merged commit 23fa95d into main Mar 9, 2023
Coding automation moved this from Reviewer approved to Done Mar 9, 2023
@KnorpelSenf KnorpelSenf deleted the safe-init branch March 9, 2023 01:21
src/bot.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants