Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect type in getMyDefaultAdministratorRights #375

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

dcdunkan
Copy link
Member

@dcdunkan dcdunkan commented Mar 8, 2023

It should be get... not set... in the other parameter.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (ee66178) 36.65% compared to head (2e5dfc4) 36.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #375   +/-   ##
=======================================
  Coverage   36.65%   36.65%           
=======================================
  Files          18       18           
  Lines        4602     4602           
  Branches      166      166           
=======================================
  Hits         1687     1687           
  Misses       2913     2913           
  Partials        2        2           
Impacted Files Coverage Δ
src/core/api.ts 4.91% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KnorpelSenf KnorpelSenf merged commit 59c5379 into main Mar 8, 2023
@KnorpelSenf KnorpelSenf deleted the fix-getmydefaultadminrights branch March 8, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants