fix: plugin types compatibility issue with ctx.has #268
Conversation
|
This PR fixes the issue that resulted in typescript error being thrown when extending However, it features additive implementation of I think that this caveat is minor compared to the original issue. If we are unable to come up with a better alternative, this should be merged until we either find a better solution or split The original problem is very serious as it breaks numerous plugins |
src/filter.ts
Outdated
| @@ -433,6 +433,10 @@ type Combine<U, K extends string> = U extends unknown | |||
| ? U & Partial<Record<Exclude<K, keyof U>, undefined>> | |||
| : never; | |||
|
|
|||
| export type FilterE<Q extends FilterQuery> = PerformQueryE< | |||
There was a problem hiding this comment.
This is a great PQ, I'd just love to have a better suffix than E. What does it stand for, extension maybe?
There was a problem hiding this comment.
Let me throw a bunch of random names at you:
- FilterExtension
- FilterCore
- FilterAddition
- FilterCasing
- FilterShell
- FilterCover
- FilterSide
- FilterWing
- FilterAugmentation
- FilterEnhancement
- FilterAppendix
- FilterAttachment
- FilterAddendum
I think I prefer FilterCore. Which one do you like best?
There was a problem hiding this comment.
Alright, let's rename then. Can you take care of this?
There was a problem hiding this comment.
What about exports and typedoc comments?
There was a problem hiding this comment.
I don't really think we need to export the *Core types. I see no reason to do this, as userland code would likely always want to use the full types. If there's ever demand for this, we can still export it in the future.
JSDoc comments are only necessary for exported stuff. Internal stuff may or may not have it, I'm mostly only doing this when things are hard to understand without comments.
There was a problem hiding this comment.
Great. Then it's done
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
==========================================
+ Coverage 37.24% 37.27% +0.02%
==========================================
Files 17 17
Lines 4331 4333 +2
Branches 157 157
==========================================
+ Hits 1613 1615 +2
Misses 2716 2716
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@EdJoPaTo should we wait for your review? |
Co-authored-by: Kirill Loskutov <[email protected]>
KnorpelSenf
changed the title
|
@Loskir please consider signing your commits. I'll merge anyway now, but this would be nice to have for future contributions :) |
Fixes #263