Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change description for keyboard.build #259

Merged
merged 8 commits into from
Sep 10, 2022

Conversation

Loskir
Copy link
Contributor

@Loskir Loskir commented Aug 4, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Aug 4, 2022

Codecov Report

Base: 37.14% // Head: 37.20% // Increases project coverage by +0.05% 🎉

Coverage data is based on head (9ca4662) compared to base (401fc21).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
+ Coverage   37.14%   37.20%   +0.05%     
==========================================
  Files          17       17              
  Lines        4348     4352       +4     
  Branches      157      157              
==========================================
+ Hits         1615     1619       +4     
  Misses       2731     2731              
  Partials        2        2              
Impacted Files Coverage Δ
src/convenience/keyboard.ts 100.00% <ø> (ø)
src/filter.ts 90.34% <0.00%> (+0.03%) ⬆️
src/context.ts 23.09% <0.00%> (+0.06%) ⬆️
src/core/api.ts 5.28% <0.00%> (+0.08%) ⬆️
src/convenience/webhook.ts 8.60% <0.00%> (+0.99%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test.

@Loskir
Copy link
Contributor Author

Loskir commented Aug 4, 2022

How do I test it? Should I like spy on the console function?

@KnorpelSenf
Copy link
Member

Yes, that would work well. The session tests have many examples for how to use spies.

@Loskir
Copy link
Contributor Author

Loskir commented Sep 5, 2022

Maybe cancel this feature? It only affects old users anyway and I don't see much people complaining about it

@Loskir
Copy link
Contributor Author

Loskir commented Sep 5, 2022

Instead maybe deprecate build altogether?

@KnorpelSenf
Copy link
Member

Yes. We could remove it for 2.0 and just leave it as-is until then. Close this?

@Loskir Loskir marked this pull request as ready for review September 7, 2022 15:15
@Loskir Loskir changed the title Add a warning for keyboard.build Change description for keyboard.build Sep 7, 2022
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@KnorpelSenf KnorpelSenf changed the title Change description for keyboard.build fix(docs): change description for keyboard.build Sep 10, 2022
@KnorpelSenf
Copy link
Member

Consider signing your commits in the future. I will merge anyway now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants