Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webhookCallback adapter for Azure functions #257

Merged
merged 10 commits into from
Oct 6, 2022
Merged

feat: webhookCallback adapter for Azure functions #257

merged 10 commits into from
Oct 6, 2022

Conversation

vitorleo
Copy link
Contributor

@vitorleo vitorleo commented Aug 4, 2022

No description provided.

rojvv
rojvv previously requested changes Aug 4, 2022
View reviewed changes
src/convenience/frameworks.node.ts Outdated Show resolved Hide resolved
src/convenience/frameworks.node.ts Outdated Show resolved Hide resolved
dcdunkan
dcdunkan requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@dcdunkan dcdunkan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit any type errors?

src/convenience/frameworks.node.ts Outdated Show resolved Hide resolved
src/convenience/frameworks.node.ts Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2022 •
edited
Loading

Codecov Report

Base: 37.21% // Head: 37.21% // No change to project coverage 👍

Coverage data is based on head (dc18eb2) compared to base (33c00b5).
Patch has no changes to coverable lines.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   37.21%   37.21%           
=======================================
  Files          17       17           
  Lines        4353     4353           
  Branches      157      157           
=======================================
  Hits         1620     1620           
  Misses       2731     2731           
  Partials        2        2

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rojvv
Copy link
Member

rojvv commented Aug 5, 2022

@vitorleo You might wanna run

deno fmt

vitorleo
vitorleo commented Aug 5, 2022
View reviewed changes
Copy link
Contributor Author

@vitorleo vitorleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

KnorpelSenf
KnorpelSenf approved these changes Aug 28, 2022
View reviewed changes
Copy link
Member

@KnorpelSenf KnorpelSenf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KnorpelSenf KnorpelSenf changed the title webhookCallback adapter for azure functions feat: webhookCallback adapter for Azure functions Sep 5, 2022
@KnorpelSenf
Copy link
Member

This somehow got lost, I don't remember why it wasn't merged yet?

As discovered in #283 already, CI currently fails due to the recent TS 4.8 update. It will be fixed upstream, merged here, and then I'm happy to see this landing right away!

@KnorpelSenf
Copy link
Member

Waiting for a review of #284.

@KnorpelSenf
Copy link
Member

@vitorleo please consider signing your commits in the future. We usually require this—I'll merge anyway now :)

@KnorpelSenf KnorpelSenf merged commit b5d33cb into grammyjs:main Oct 6, 2022
@KnorpelSenf
Copy link
Member

@all-contributors add @vitorleo for code!

@allcontributors allcontributors bot mentioned this pull request Oct 7, 2022
Merged
@allcontributors
Copy link
Contributor

@KnorpelSenf

I've put up a pull request to add @vitorleo! 🎉

@KnorpelSenf KnorpelSenf mentioned this pull request Oct 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnorpelSenf KnorpelSenf KnorpelSenf approved these changes

@dcdunkan dcdunkan dcdunkan approved these changes

@rojvv rojvv Awaiting requested review from rojvv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vitorleo @codecov-commenter @rojvv @KnorpelSenf @dcdunkan